[Merged by Bors] - Labelled ByteCompiler Fix #2534
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nekevss
added
execution
Codecov Report
@@ Coverage Diff @@
## main #2534 +/- ##
==========================================
+ Coverage 49.92% 50.11% +0.18%
==========================================
Files 377 377
Lines 37557 37438 -119
==========================================
+ Hits 18751 18761 +10
+ Misses 18806 18677 -129
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
nekevss
requested review from
jedel1043,
HalidOdat,
jasonwilliams,
RageKnify,
raskad and
Razican
nekevss
force-pushed
the
labelled-compiler-fix
branch
from
c776af7 to
0335e1e
Compare
Since there are no early errors or specific places where execution depends on the statements being |
raskad
approved these changes
Jan 19, 2023
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jan 19, 2023
<!--- Thank you for contributing to Boa! Please fill out the template below, and remove or add any information as you feel necessary. ---> This Pull Request addresses #2295, and another case that I came across when I was adding `Break` to the `ByteCompiler` I did have a question that came up during this regarding the spec. We currently don't implement the [BreakableStatement](https://tc39.es/ecma262/#prod-BreakableStatement). Any thoughts on whether we should be? Especially since `BreakableStatement` seems to be a bit of a inaccurate since `LabelledStatement` is breakable too. It changes the following: - Moves handling of label jump out of `compile_block` and into `compile_labelled`. - Adds a couple more tests to keep track of `LabelledStatement` breaks. Co-authored-by: Ness <[email protected]>
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request addresses #2295, and another case that I came across when I was adding
Breakto theByteCompilerI did have a question that came up during this regarding the spec. We currently don't implement the BreakableStatement. Any thoughts on whether we should be? Especially since
BreakableStatementseems to be a bit of a inaccurate sinceLabelledStatementis breakable too.It changes the following:
compile_blockand intocompile_labelled.LabelledStatementbreaks.