-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Fix some HoistableDeclaration parsing errors #2532
Conversation
Test262 conformance changes
Fixed tests (8):
|
Codecov Report
@@ Coverage Diff @@
## main #2532 +/- ##
==========================================
- Coverage 50.16% 50.15% -0.01%
==========================================
Files 377 377
Lines 37469 37506 +37
==========================================
+ Hits 18795 18810 +15
- Misses 18674 18696 +22
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
bors r+ |
This Pull Request hanges the following: - Add early errors for invalid `yield` and `await` usage in function parameters. - Add missing function types to hoistable ordering. - Do not attempt to parse `async` with a following line terminator as an async function.
Pull request successfully merged into main. Build succeeded: |
This Pull Request hanges the following:
yield
andawait
usage in function parameters.async
with a following line terminator as an async function.