Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Add regex literal early errors #2517

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Add regex literal early errors #2517

wants to merge 1 commit into from

Conversation

raskad
Copy link
Member

@raskad raskad commented Jan 5, 2023

This Pull Request changes the following:

  • Parse regex literals via regress during parsing to return errors in the regex as early syntax errors.

@raskad raskad added bug Something isn't working parser Issues surrounding the parser labels Jan 5, 2023
@raskad raskad added this to the v0.17.0 milestone Jan 5, 2023
@github-actions
Copy link

github-actions bot commented Jan 5, 2023

Test262 conformance changes

Test result main count PR count difference
Total 94,188 94,188 0
Passed 70,164 70,298 +134
Ignored 18,605 18,605 0
Failed 5,419 5,285 -134
Panics 0 0 0
Conformance 74.49% 74.64% +0.14%
Fixed tests (134): 
test/language/literals/regexp/early-err-pattern.js [strict mode] (previously Failed)
test/language/literals/regexp/early-err-pattern.js (previously Failed)
test/language/literals/regexp/invalid-braced-quantifier-exact.js [strict mode] (previously Failed)
test/language/literals/regexp/invalid-braced-quantifier-exact.js (previously Failed)
test/language/literals/regexp/u-invalid-class-escape.js [strict mode] (previously Failed)
test/language/literals/regexp/u-invalid-class-escape.js (previously Failed)
test/language/literals/regexp/u-invalid-legacy-octal-escape.js [strict mode] (previously Failed)
test/language/literals/regexp/u-invalid-legacy-octal-escape.js (previously Failed)
test/language/literals/regexp/u-invalid-optional-negative-lookahead.js [strict mode] (previously Failed)
test/language/literals/regexp/u-invalid-optional-negative-lookahead.js (previously Failed)
test/language/literals/regexp/u-invalid-range-negative-lookahead.js [strict mode] (previously Failed)
test/language/literals/regexp/u-invalid-range-negative-lookahead.js (previously Failed)
test/language/literals/regexp/u-invalid-non-empty-class-ranges.js [strict mode] (previously Failed)
test/language/literals/regexp/u-invalid-non-empty-class-ranges.js (previously Failed)
test/language/literals/regexp/invalid-braced-quantifier-lower.js [strict mode] (previously Failed)
test/language/literals/regexp/invalid-braced-quantifier-lower.js (previously Failed)
test/language/literals/regexp/u-invalid-optional-lookahead.js [strict mode] (previously Failed)
test/language/literals/regexp/u-invalid-optional-lookahead.js (previously Failed)
test/language/literals/regexp/u-unicode-esc-non-hex.js [strict mode] (previously Failed)
test/language/literals/regexp/u-unicode-esc-non-hex.js (previously Failed)
test/language/literals/regexp/u-invalid-oob-decimal-escape.js [strict mode] (previously Failed)
test/language/literals/regexp/u-invalid-oob-decimal-escape.js (previously Failed)
test/language/literals/regexp/u-invalid-range-lookahead.js [strict mode] (previously Failed)
test/language/literals/regexp/u-invalid-range-lookahead.js (previously Failed)
test/language/literals/regexp/u-unicode-esc-bounds.js [strict mode] (previously Failed)
test/language/literals/regexp/u-unicode-esc-bounds.js (previously Failed)
test/language/literals/regexp/u-invalid-non-empty-class-ranges-no-dash-b.js [strict mode] (previously Failed)
test/language/literals/regexp/u-invalid-non-empty-class-ranges-no-dash-b.js (previously Failed)
test/language/literals/regexp/u-invalid-non-empty-class-ranges-no-dash-a.js [strict mode] (previously Failed)
test/language/literals/regexp/u-invalid-non-empty-class-ranges-no-dash-a.js (previously Failed)
test/language/literals/regexp/invalid-braced-quantifier-range.js [strict mode] (previously Failed)
test/language/literals/regexp/invalid-braced-quantifier-range.js (previously Failed)
test/language/literals/regexp/unicode-escape-nls-err.js [strict mode] (previously Failed)
test/language/literals/regexp/unicode-escape-nls-err.js (previously Failed)
test/language/literals/regexp/u-invalid-non-empty-class-ranges-no-dash-ab.js [strict mode] (previously Failed)
test/language/literals/regexp/u-invalid-non-empty-class-ranges-no-dash-ab.js (previously Failed)
test/language/literals/regexp/named-groups/invalid-unterminated-groupspecifier-u.js [strict mode] (previously Failed)
test/language/literals/regexp/named-groups/invalid-unterminated-groupspecifier-u.js (previously Failed)
test/language/literals/regexp/named-groups/invalid-non-id-start-groupspecifier-6.js [strict mode] (previously Failed)
test/language/literals/regexp/named-groups/invalid-non-id-start-groupspecifier-6.js (previously Failed)
test/language/literals/regexp/named-groups/invalid-incomplete-groupname-2-u.js [strict mode] (previously Failed)
test/language/literals/regexp/named-groups/invalid-incomplete-groupname-2-u.js (previously Failed)
test/language/literals/regexp/named-groups/invalid-dangling-groupname-5.js [strict mode] (previously Failed)
test/language/literals/regexp/named-groups/invalid-dangling-groupname-5.js (previously Failed)
test/language/literals/regexp/named-groups/invalid-non-id-continue-groupspecifier-4-u.js [strict mode] (previously Failed)
test/language/literals/regexp/named-groups/invalid-non-id-continue-groupspecifier-4-u.js (previously Failed)
test/language/literals/regexp/named-groups/invalid-non-id-start-groupspecifier-5.js [strict mode] (previously Failed)
test/language/literals/regexp/named-groups/invalid-non-id-start-groupspecifier-5.js (previously Failed)
test/language/literals/regexp/named-groups/invalid-non-id-start-groupspecifier-4-u.js [strict mode] (previously Failed)
test/language/literals/regexp/named-groups/invalid-non-id-start-groupspecifier-4-u.js (previously Failed)
test/language/literals/regexp/named-groups/invalid-unterminated-groupspecifier.js [strict mode] (previously Failed)
test/language/literals/regexp/named-groups/invalid-unterminated-groupspecifier.js (previously Failed)
test/language/literals/regexp/named-groups/invalid-dangling-groupname-3-u.js [strict mode] (previously Failed)
test/language/literals/regexp/named-groups/invalid-dangling-groupname-3-u.js (previously Failed)
test/language/literals/regexp/named-groups/invalid-punctuator-within-groupspecifier.js [strict mode] (previously Failed)
test/language/literals/regexp/named-groups/invalid-punctuator-within-groupspecifier.js (previously Failed)
test/language/literals/regexp/named-groups/invalid-non-id-start-groupspecifier-9-u.js [strict mode] (previously Failed)
test/language/literals/regexp/named-groups/invalid-non-id-start-groupspecifier-9-u.js (previously Failed)
test/language/literals/regexp/named-groups/invalid-dangling-groupname-3.js [strict mode] (previously Failed)
test/language/literals/regexp/named-groups/invalid-dangling-groupname-3.js (previously Failed)
test/language/literals/regexp/named-groups/invalid-incomplete-groupname.js [strict mode] (previously Failed)
test/language/literals/regexp/named-groups/invalid-incomplete-groupname.js (previously Failed)
test/language/literals/regexp/named-groups/invalid-dangling-groupname.js [strict mode] (previously Failed)
test/language/literals/regexp/named-groups/invalid-dangling-groupname.js (previously Failed)
test/language/literals/regexp/named-groups/invalid-dangling-groupname-u.js [strict mode] (previously Failed)
test/language/literals/regexp/named-groups/invalid-dangling-groupname-u.js (previously Failed)
test/language/literals/regexp/named-groups/invalid-dangling-groupname-4-u.js [strict mode] (previously Failed)
test/language/literals/regexp/named-groups/invalid-dangling-groupname-4-u.js (previously Failed)
test/language/literals/regexp/named-groups/invalid-incomplete-groupname-5.js [strict mode] (previously Failed)
test/language/literals/regexp/named-groups/invalid-incomplete-groupname-5.js (previously Failed)
test/language/literals/regexp/named-groups/invalid-non-id-continue-groupspecifier.js [strict mode] (previously Failed)
test/language/literals/regexp/named-groups/invalid-non-id-continue-groupspecifier.js (previously Failed)
test/language/literals/regexp/named-groups/invalid-dangling-groupname-4.js [strict mode] (previously Failed)
test/language/literals/regexp/named-groups/invalid-dangling-groupname-4.js (previously Failed)
test/language/literals/regexp/named-groups/invalid-dangling-groupname-without-group-u.js [strict mode] (previously Failed)
test/language/literals/regexp/named-groups/invalid-dangling-groupname-without-group-u.js (previously Failed)
test/language/literals/regexp/named-groups/invalid-incomplete-groupname-6.js [strict mode] (previously Failed)
test/language/literals/regexp/named-groups/invalid-incomplete-groupname-6.js (previously Failed)
test/language/literals/regexp/named-groups/invalid-dangling-groupname-2.js [strict mode] (previously Failed)
test/language/literals/regexp/named-groups/invalid-dangling-groupname-2.js (previously Failed)
test/language/literals/regexp/named-groups/invalid-non-id-start-groupspecifier.js [strict mode] (previously Failed)
test/language/literals/regexp/named-groups/invalid-non-id-start-groupspecifier.js (previously Failed)
test/language/literals/regexp/named-groups/invalid-incomplete-groupname-3-u.js [strict mode] (previously Failed)
test/language/literals/regexp/named-groups/invalid-incomplete-groupname-3-u.js (previously Failed)
test/language/literals/regexp/named-groups/invalid-non-id-continue-groupspecifier-4.js [strict mode] (previously Failed)
test/language/literals/regexp/named-groups/invalid-non-id-continue-groupspecifier-4.js (previously Failed)
test/language/literals/regexp/named-groups/invalid-incomplete-groupname-without-group-u.js [strict mode] (previously Failed)
test/language/literals/regexp/named-groups/invalid-incomplete-groupname-without-group-u.js (previously Failed)
test/language/literals/regexp/named-groups/invalid-non-id-start-groupspecifier-8.js [strict mode] (previously Failed)
test/language/literals/regexp/named-groups/invalid-non-id-start-groupspecifier-8.js (previously Failed)
test/language/literals/regexp/named-groups/invalid-incomplete-groupname-2.js [strict mode] (previously Failed)
test/language/literals/regexp/named-groups/invalid-incomplete-groupname-2.js (previously Failed)
test/language/literals/regexp/named-groups/invalid-incomplete-groupname-without-group-3-u.js [strict mode] (previously Failed)
test/language/literals/regexp/named-groups/invalid-incomplete-groupname-without-group-3-u.js (previously Failed)
test/language/literals/regexp/named-groups/invalid-dangling-groupname-2-u.js [strict mode] (previously Failed)
test/language/literals/regexp/named-groups/invalid-dangling-groupname-2-u.js (previously Failed)
test/language/literals/regexp/named-groups/invalid-punctuator-starting-groupspecifier-u.js [strict mode] (previously Failed)
test/language/literals/regexp/named-groups/invalid-punctuator-starting-groupspecifier-u.js (previously Failed)
test/language/literals/regexp/named-groups/invalid-non-id-start-groupspecifier-2-u.js [strict mode] (previously Failed)
test/language/literals/regexp/named-groups/invalid-non-id-start-groupspecifier-2-u.js (previously Failed)
test/language/literals/regexp/named-groups/invalid-incomplete-groupname-u.js [strict mode] (previously Failed)
test/language/literals/regexp/named-groups/invalid-incomplete-groupname-u.js (previously Failed)
test/language/literals/regexp/named-groups/invalid-non-id-start-groupspecifier-8-u.js [strict mode] (previously Failed)
test/language/literals/regexp/named-groups/invalid-non-id-start-groupspecifier-8-u.js (previously Failed)
test/language/literals/regexp/named-groups/invalid-incomplete-groupname-without-group-2-u.js [strict mode] (previously Failed)
test/language/literals/regexp/named-groups/invalid-incomplete-groupname-without-group-2-u.js (previously Failed)
test/language/literals/regexp/named-groups/invalid-numeric-groupspecifier.js [strict mode] (previously Failed)
test/language/literals/regexp/named-groups/invalid-numeric-groupspecifier.js (previously Failed)
test/language/literals/regexp/named-groups/invalid-non-id-start-groupspecifier-4.js [strict mode] (previously Failed)
test/language/literals/regexp/named-groups/invalid-non-id-start-groupspecifier-4.js (previously Failed)
test/language/literals/regexp/named-groups/invalid-incomplete-groupname-3.js [strict mode] (previously Failed)
test/language/literals/regexp/named-groups/invalid-incomplete-groupname-3.js (previously Failed)
test/language/literals/regexp/named-groups/invalid-punctuator-starting-groupspecifier.js [strict mode] (previously Failed)
test/language/literals/regexp/named-groups/invalid-punctuator-starting-groupspecifier.js (previously Failed)
test/language/literals/regexp/named-groups/invalid-non-id-start-groupspecifier-5-u.js [strict mode] (previously Failed)
test/language/literals/regexp/named-groups/invalid-non-id-start-groupspecifier-5-u.js (previously Failed)
test/language/literals/regexp/named-groups/invalid-empty-groupspecifier-u.js [strict mode] (previously Failed)
test/language/literals/regexp/named-groups/invalid-empty-groupspecifier-u.js (previously Failed)
test/language/literals/regexp/named-groups/invalid-non-id-start-groupspecifier-u.js [strict mode] (previously Failed)
test/language/literals/regexp/named-groups/invalid-non-id-start-groupspecifier-u.js (previously Failed)
test/language/literals/regexp/named-groups/invalid-non-id-start-groupspecifier-3.js [strict mode] (previously Failed)
test/language/literals/regexp/named-groups/invalid-non-id-start-groupspecifier-3.js (previously Failed)
test/language/literals/regexp/named-groups/invalid-punctuator-within-groupspecifier-u.js [strict mode] (previously Failed)
test/language/literals/regexp/named-groups/invalid-punctuator-within-groupspecifier-u.js (previously Failed)
test/language/literals/regexp/named-groups/invalid-non-id-start-groupspecifier-7.js [strict mode] (previously Failed)
test/language/literals/regexp/named-groups/invalid-non-id-start-groupspecifier-7.js (previously Failed)
test/language/literals/regexp/named-groups/invalid-empty-groupspecifier.js [strict mode] (previously Failed)
test/language/literals/regexp/named-groups/invalid-empty-groupspecifier.js (previously Failed)
test/language/literals/regexp/named-groups/invalid-incomplete-groupname-4.js [strict mode] (previously Failed)
test/language/literals/regexp/named-groups/invalid-incomplete-groupname-4.js (previously Failed)
test/language/literals/regexp/named-groups/invalid-numeric-groupspecifier-u.js [strict mode] (previously Failed)
test/language/literals/regexp/named-groups/invalid-numeric-groupspecifier-u.js (previously Failed)
test/language/literals/regexp/named-groups/invalid-non-id-start-groupspecifier-2.js [strict mode] (previously Failed)
test/language/literals/regexp/named-groups/invalid-non-id-start-groupspecifier-2.js (previously Failed)

@codecov
Copy link

codecov bot commented Jan 5, 2023 •
edited
Loading

Codecov Report

Merging #2517 (63ca528) into main (1b04c9e) will increase coverage by 0.89%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2517      +/-   ##
==========================================
+ Coverage   50.68%   51.57%   +0.89%     
==========================================
  Files         358      356       -2     
  Lines       36265    35662     -603     
==========================================
+ Hits        18380    18392      +12     
+ Misses      17885    17270     -615
Impacted Files Coverage Δ
boa_parser/src/lexer/regex.rs 62.85% <100.00%> (+3.45%) ⬆️
boa_engine/src/builtins/regexp/mod.rs 65.76% <0.00%> (-0.65%) ⬇️
boa_ast/src/visitor.rs 10.58% <0.00%> (-0.59%) ⬇️
boa_engine/src/object/mod.rs 44.22% <0.00%> (-0.11%) ⬇️
boa_tester/src/main.rs 0.00% <0.00%> (ø)
boa_examples/src/bin/loadstring.rs
boa_tester/src/results.rs
boa_tester/src/exec/js262.rs
boa_tester/src/exec/mod.rs
boa_tester/src/read.rs
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

HalidOdat
HalidOdat approved these changes Jan 7, 2023
View reviewed changes
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

jedel1043
jedel1043 approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Would be good to store the parsed Regex instead of parsing it again on the engine, but that should be on a separate PR.

@jedel1043
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Jan 12, 2023
@raskad
Add regex literal early errors (#2517)
be9ebc9 
This Pull Request changes the following:

- Parse regex literals via `regress` during parsing to return errors in the regex as early syntax errors.
@bors
Copy link

bors bot commented Jan 12, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Add regex literal early errors [Merged by Bors] - Add regex literal early errors Jan 12, 2023
@bors bors bot closed this Jan 12, 2023
@bors bors bot deleted the regexp-literal-parse-syntax-error branch January 12, 2023 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedel1043 jedel1043 jedel1043 approved these changes

@HalidOdat HalidOdat HalidOdat approved these changes

@Razican Razican Awaiting requested review from Razican

@jasonwilliams jasonwilliams Awaiting requested review from jasonwilliams

@nekevss nekevss Awaiting requested review from nekevss

@RageKnify RageKnify Awaiting requested review from RageKnify

Assignees
No one assigned
Labels
bug Something isn't working parser Issues surrounding the parser
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.
3 participants
@raskad @jedel1043 @HalidOdat