Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Pass locale data provider by ref instead of boxing #2508

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - Pass locale data provider by ref instead of boxing #2508

wants to merge 7 commits into from

Conversation

jedel1043
Copy link
Member

@jedel1043 jedel1043 commented Dec 26, 2022 •
edited
Loading

This change is actually pretty simple, but since now we have to pass a lifetime parameter to all references of Context, it touches a lot of files.

Relevant changes:

All the other changes are just replacing Context with Context<'_>.

@jedel1043 jedel1043 added performance Performance related changes and issues API labels Dec 26, 2022
@jedel1043 jedel1043 added this to the v0.17.0 milestone Dec 26, 2022
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 94,188 94,188 0
Passed 70,164 70,164 0
Ignored 18,605 18,605 0
Failed 5,419 5,419 0
Panics 0 0 0
Conformance 74.49% 74.49% 0.00%

@codecov
Copy link

codecov bot commented Dec 26, 2022 •
edited
Loading

Codecov Report

Merging #2508 (b31b1b0) into main (cbf0782) will increase coverage by 0.02%.
The diff coverage is 50.78%.

@@            Coverage Diff             @@
##             main    #2508      +/-   ##
==========================================
+ Coverage   51.62%   51.64%   +0.02%     
==========================================
  Files         355      353       -2     
  Lines       35621    35579      -42     
==========================================
- Hits        18388    18376      -12     
+ Misses      17233    17203      -30
Impacted Files Coverage Δ
boa_cli/src/main.rs 0.00% <ø> (ø)
boa_engine/src/builtins/function/arguments.rs 96.66% <ø> (ø)
...oa_engine/src/builtins/intl/list_format/options.rs 0.00% <0.00%> (ø)
boa_engine/src/builtins/intl/locale/options.rs 0.00% <0.00%> (ø)
boa_engine/src/builtins/intl/options.rs 0.00% <0.00%> (ø)
boa_engine/src/builtins/promise/promise_job.rs 45.12% <0.00%> (ø)
boa_engine/src/bytecompiler/class.rs 0.00% <ø> (ø)
...rc/bytecompiler/declaration/declaration_pattern.rs 26.71% <ø> (ø)
boa_engine/src/bytecompiler/expression/binary.rs 81.03% <ø> (ø)
boa_engine/src/bytecompiler/expression/mod.rs 51.63% <ø> (ø)
... and 180 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

HalidOdat
HalidOdat approved these changes Dec 27, 2022
View reviewed changes
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@jedel1043
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Dec 27, 2022
@jedel1043
Pass locale data provider by ref instead of boxing (#2508)
81680ff 
This change is actually pretty simple, but since now we have to pass a lifetime parameter to all references of `Context`, it touches a lot of files.

Relevant changes:

- https://github.com/boa-dev/boa/pull/2508/files#diff-73e17259d77e5fbef83b2bdbbe4dc40a912f807472287f7f45b77e0cbf78792d

- https://github.com/boa-dev/boa/pull/2508/files#diff-e7ebcd61f7a01c432b62e1742a6cfd8e28326a1f2b6afb37ba66d4964b3db521

- https://github.com/boa-dev/boa/pull/2508/files#diff-7b2a85f5aa9b5a8070e04e87a67b4f7cc700a43a520e0d6cc6e0b701711ccb7c

- https://github.com/boa-dev/boa/pull/2508/files#diff-872037c107c01bf644ede412e4802b3eefeb5a70ce595c441f75651d45111b2a

- https://github.com/boa-dev/boa/pull/2508/files#diff-a665b3b6f564521875fd0d725bffbc4f0cc84e5feefdc5fd875fd943e56311cd

- https://github.com/boa-dev/boa/pull/2508/files#diff-3e1f19581f227120ddc3334fd0450152b767811c9b6cb4048581347fcd9fc91d

- https://github.com/boa-dev/boa/pull/2508/files#diff-5fe65193a910618375d9575d918cd584430437ee2738a987c92068dea3117297

- https://github.com/boa-dev/boa/pull/2508/files#diff-4ce8770f8aaf50785ece12a9a15b781a544bfc47f080e2ff62ddfb18264a44ef

All the other changes are just replacing `Context` with `Context<'_>`.
@bors
Copy link

bors bot commented Dec 27, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Pass locale data provider by ref instead of boxing [Merged by Bors] - Pass locale data provider by ref instead of boxing Dec 27, 2022
@bors bors bot closed this Dec 27, 2022
@bors bors bot deleted the provider-ref branch December 27, 2022 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nekevss nekevss nekevss approved these changes

@HalidOdat HalidOdat HalidOdat approved these changes

@Razican Razican Awaiting requested review from Razican

@jasonwilliams jasonwilliams Awaiting requested review from jasonwilliams

@RageKnify RageKnify Awaiting requested review from RageKnify

@raskad raskad Awaiting requested review from raskad

Assignees
No one assigned
Labels
API performance Performance related changes and issues
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jedel1043 @HalidOdat @nekevss