[Merged by Bors] - Fix unary operations on this
#2507
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedel1043
requested review from
raskad,
jedel1043,
HalidOdat,
jasonwilliams,
nekevss,
RageKnify and
Razican
jedel1043
added
bug
jedel1043
reviewed
Dec 26, 2022
Codecov Report
@@ Coverage Diff @@
## main #2507 +/- ##
==========================================
- Coverage 52.99% 51.64% -1.36%
==========================================
Files 343 355 +12
Lines 34755 35619 +864
==========================================
- Hits 18419 18396 -23
- Misses 16336 17223 +887
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jedel1043
requested changes
Dec 26, 2022
veera-sivarajan
requested review from
jedel1043
and removed request for
Razican,
jasonwilliams,
HalidOdat,
RageKnify,
raskad and
nekevss
jedel1043
requested changes
Dec 27, 2022
Test262 conformance changes
|
jedel1043
reviewed
Dec 27, 2022
There was a problem hiding this comment.
Implementation-wise looks good! Can you add a test case on https://github.com/boa-dev/boa/blob/main/boa_engine/src/tests.rs? I thought the test262 suite would catch this, but apparently it doesn't...
|
There are some failing checks. Can you run |
jedel1043
requested review from
raskad,
Razican,
HalidOdat,
jasonwilliams,
RageKnify and
nekevss
Razican
reviewed
Dec 28, 2022
veera-sivarajan
requested review from
Razican
and removed request for
raskad,
HalidOdat,
jasonwilliams,
RageKnify and
nekevss
Razican
approved these changes
Dec 30, 2022
|
Bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Dec 30, 2022
<!--- Thank you for contributing to Boa! Please fill out the template below, and remove or add any information as you feel necessary. ---> This Pull Request fixes/closes #2416. Previously, prefix increment and decrement operations on `this` caused a panic. This PR makes the parser issue a syntax error when the operand UnaryExpression is not simple (as mentioned in https://tc39.es/ecma262/#sec-update-expressions-static-semantics-early-errors).
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
thisthis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #2416.
Previously, prefix increment and decrement operations on
thiscaused a panic. This PR makes the parser issue a syntax error when the operand UnaryExpression is not simple (as mentioned in https://tc39.es/ecma262/#sec-update-expressions-static-semantics-early-errors).