[Merged by Bors] - [profiler] Cache StringId #2495
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boa_profiler was allocating new strings every time even when they are the same string. This change updates the profiler to use a cache and avoid duplicate allocations.
Codecov Report
@@ Coverage Diff @@
## main #2495 +/- ##
==========================================
+ Coverage 52.40% 53.02% +0.62%
==========================================
Files 339 342 +3
Lines 35170 34720 -450
==========================================
- Hits 18431 18412 -19
+ Misses 16739 16308 -431
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jedel1043
approved these changes
Dec 20, 2022
jedel1043
requested review from
raskad,
Razican,
jasonwilliams,
HalidOdat,
nekevss and
RageKnify
jedel1043
added
execution
raskad
requested changes
Dec 20, 2022
There was a problem hiding this comment.
Looks fine to me, but I'd say let's change the unwraps like @jedel1043 suggested to stick to our normal lint rules.
raskad
approved these changes
Dec 27, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Dec 27, 2022
boa_profiler was allocating new strings every time even when they are the same string, which leads to a crash when `start_event` is called too much. This change updates the profiler to use a hash map cache and avoid duplicate string allocations.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
boa_profiler was allocating new strings every time even when they are the same string, which leads to a crash when
start_eventis called too much. This change updates the profiler to use a hash map cache and avoid duplicate string allocations.