[Merged by Bors] - Cleanup inline annotations #2493
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedel1043
added
technical debt
Internal
jedel1043
requested review from
Razican,
jasonwilliams,
HalidOdat,
RageKnify,
raskad and
nekevss
Test262 conformance changes
|
Codecov Report
@@ Coverage Diff @@
## main #2493 +/- ##
==========================================
+ Coverage 52.74% 52.80% +0.05%
==========================================
Files 344 343 -1
Lines 34952 34874 -78
==========================================
- Hits 18435 18414 -21
+ Misses 16517 16460 -57
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Benchmark for 78e2605Click to view benchmark
|
|
Everything looks good! This should be alright then. |
RageKnify
reviewed
Dec 19, 2022
|
Huh, the spaces between docs and functions are the kind of thing I expected rustfmt to catch, but I guess not... |
RageKnify
suggested changes
Dec 19, 2022
There was a problem hiding this comment.
Just have the one question regarding why you removed the From<&Value> for Value implementation.
Also I don't want to spam with a bunch of comments that say the same, but there were a few functions where instead of deleting the line with the #[inline] annotation you replaced it with an empty line.
I think having the empty line between doc-comments/other annotations and the functions doesn't help readability, it's nice to have them be close together to I'd prefer you made them all the same.
edit: nvm, you've handled it and I agree, weird that rustfmt doesn't handle it
Comment on lines
-3
to
-9
| impl From<&Self> for JsValue { | ||
| #[inline] | ||
| fn from(value: &Self) -> Self { | ||
| value.clone() | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
This is what made it so you had to add the .clone()s around the code-base right?
Why did you remove it?
There was a problem hiding this comment.
Mainly because Rust tends to be very explicit about new allocations, and a From<&T> for T implementation goes against that.
Benchmark for cc4bbfaClick to view benchmark
|
Benchmark for 9d8c6d2Click to view benchmark
|
Razican
reviewed
Dec 20, 2022
Current discussion about this: #2493 (comment) |
jedel1043
force-pushed
the
inline-checks
branch
from
8316564 to
daed3c8
Compare
Benchmark for a886c8fClick to view benchmark
|
HalidOdat
approved these changes
Dec 20, 2022
bors bot
pushed a commit
that referenced
this pull request
Dec 20, 2022
Per the [Standard Library development guide](https://std-dev-guide.rust-lang.org/code-considerations/performance/inline.html): > You can add `#[inline]`: > > - To public, small, non-generic functions. > > You shouldn't need `#[inline]`: > - On methods that have any generics in scope. > - On methods on traits that don't have a default implementation. > > `#[inline]` can always be introduced later, so if you're in doubt they can just be removed. This PR follows this guideline to reduce the number of `#[inline]` annotations in our code, removing the annotation in: - Non-public functions - Generic functions - Medium and big functions. Hopefully this shouldn't impact our perf at all, but let's wait to see the benchmark results.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the Standard Library development guide:
This PR follows this guideline to reduce the number of
#[inline]annotations in our code, removing the annotation in:Hopefully this shouldn't impact our perf at all, but let's wait to see the benchmark results.