Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Allow class expressions without identifier #2464

Closed
wants to merge 1 commit into from

Conversation

raskad
Copy link
Member

@raskad raskad commented Nov 27, 2022

This Pull Request changes the following:

  • Remove false early error when a class expression was missing a binding identifier.
  • Simplify/fix environment truncation on function returns.

The new failed tests where false positives before that will be fixed in another PR.

@raskad raskad added bug Something isn't working parser Issues surrounding the parser execution Issues or PRs related to code execution labels Nov 27, 2022
@raskad raskad added this to the v0.17.0 milestone Nov 27, 2022
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 93,831 93,831 0
Passed 69,664 69,704 +40
Ignored 18,472 18,472 0
Failed 5,695 5,655 -40
Panics 0 0 0
Conformance 74.24% 74.29% +0.04%
Fixed tests (44):
test/language/expressions/class/name.js [strict mode] (previously Failed)
test/language/expressions/class/name.js (previously Failed)
test/language/expressions/class/accessor-name-static/computed-err-evaluation.js [strict mode] (previously Failed)
test/language/expressions/class/accessor-name-static/computed-err-evaluation.js (previously Failed)
test/language/expressions/class/accessor-name-static/computed-err-unresolvable.js [strict mode] (previously Failed)
test/language/expressions/class/accessor-name-static/computed-err-unresolvable.js (previously Failed)
test/language/expressions/class/accessor-name-static/computed-err-to-prop-key.js [strict mode] (previously Failed)
test/language/expressions/class/accessor-name-static/computed-err-to-prop-key.js (previously Failed)
test/language/expressions/class/accessor-name-inst/computed-err-evaluation.js [strict mode] (previously Failed)
test/language/expressions/class/accessor-name-inst/computed-err-evaluation.js (previously Failed)
test/language/expressions/class/accessor-name-inst/computed-err-unresolvable.js [strict mode] (previously Failed)
test/language/expressions/class/accessor-name-inst/computed-err-unresolvable.js (previously Failed)
test/language/expressions/class/accessor-name-inst/computed-err-to-prop-key.js [strict mode] (previously Failed)
test/language/expressions/class/accessor-name-inst/computed-err-to-prop-key.js (previously Failed)
test/language/expressions/object/fn-name-class.js [strict mode] (previously Failed)
test/language/expressions/object/fn-name-class.js (previously Failed)
test/language/statements/class/elements/privatefieldset-typeerror-2.js [strict mode] (previously Failed)
test/language/statements/class/elements/privatefieldset-typeerror-2.js (previously Failed)
test/language/statements/class/elements/privatefieldset-typeerror-3.js [strict mode] (previously Failed)
test/language/statements/class/elements/privatefieldset-typeerror-3.js (previously Failed)
test/language/statements/class/elements/privatefieldget-success-1.js [strict mode] (previously Failed)
test/language/statements/class/elements/privatefieldget-success-1.js (previously Failed)
test/language/statements/class/elements/privatefieldget-typeerror-2.js [strict mode] (previously Failed)
test/language/statements/class/elements/privatefieldget-typeerror-2.js (previously Failed)
test/language/statements/class/elements/privatefieldget-typeerror-3.js [strict mode] (previously Failed)
test/language/statements/class/elements/privatefieldget-typeerror-3.js (previously Failed)
test/language/statements/class/subclass/derived-class-return-override-catch-super-arrow.js [strict mode] (previously Failed)
test/language/statements/class/subclass/derived-class-return-override-catch-super-arrow.js (previously Failed)
test/language/statements/class/subclass/derived-class-return-override-finally-super.js [strict mode] (previously Failed)
test/language/statements/class/subclass/derived-class-return-override-finally-super.js (previously Failed)
test/language/statements/class/subclass/derived-class-return-override-finally-super-arrow.js [strict mode] (previously Failed)
test/language/statements/class/subclass/derived-class-return-override-finally-super-arrow.js (previously Failed)
test/language/statements/class/subclass/derived-class-return-override-catch.js [strict mode] (previously Failed)
test/language/statements/class/subclass/derived-class-return-override-catch.js (previously Failed)
test/language/statements/class/subclass/derived-class-return-override-catch-super.js [strict mode] (previously Failed)
test/language/statements/class/subclass/derived-class-return-override-catch-super.js (previously Failed)
test/language/statements/class/subclass/derived-class-return-override-catch-finally-arrow.js [strict mode] (previously Failed)
test/language/statements/class/subclass/derived-class-return-override-catch-finally-arrow.js (previously Failed)
test/language/statements/class/subclass/derived-class-return-override-catch-finally.js [strict mode] (previously Failed)
test/language/statements/class/subclass/derived-class-return-override-catch-finally.js (previously Failed)
test/built-ins/Function/internals/Call/class-ctor-realm.js [strict mode] (previously Failed)
test/built-ins/Function/internals/Call/class-ctor-realm.js (previously Failed)
test/built-ins/Function/internals/Construct/derived-return-val-realm.js [strict mode] (previously Failed)
test/built-ins/Function/internals/Construct/derived-return-val-realm.js (previously Failed)
Broken tests (4):
test/language/expressions/class/static-gen-method-param-dflt-yield.js [strict mode] (previously Passed)
test/language/expressions/class/static-gen-method-param-dflt-yield.js (previously Passed)
test/language/expressions/class/gen-method-param-dflt-yield.js [strict mode] (previously Passed)
test/language/expressions/class/gen-method-param-dflt-yield.js (previously Passed)

@codecov
Copy link

codecov bot commented Nov 27, 2022

Codecov Report

Merging #2464 (bac9b98) into main (9b56912) will increase coverage by 0.02%.
The diff coverage is 46.66%.

@@            Coverage Diff             @@
##             main    #2464      +/-   ##
==========================================
+ Coverage   51.04%   51.06%   +0.02%     
==========================================
  Files         345      346       +1     
  Lines       35963    35954       -9     
==========================================
+ Hits        18356    18359       +3     
+ Misses      17607    17595      -12     
Impacted Files Coverage Δ
.../parser/expression/primary/class_expression/mod.rs 0.00% <0.00%> (ø)
boa_engine/src/vm/code_block.rs 33.14% <50.00%> (+0.04%) ⬆️
boa_wasm/src/lib.rs 0.00% <0.00%> (ø)
boa_engine/src/object/mod.rs 46.28% <0.00%> (+0.10%) ⬆️
boa_engine/src/value/display.rs 87.31% <0.00%> (+0.74%) ⬆️
boa_engine/src/environments/runtime.rs 48.76% <0.00%> (+1.41%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@raskad
Copy link
Member Author

raskad commented Nov 29, 2022

bors r+

bors bot pushed a commit that referenced this pull request Nov 29, 2022
This Pull Request changes the following:

- Remove false early error when a class expression was missing a binding identifier.
- Simplify/fix environment truncation on function returns.

The new failed tests where false positives before that will be fixed in another PR.
@bors
Copy link

bors bot commented Nov 29, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Allow class expressions without identifier [Merged by Bors] - Allow class expressions without identifier Nov 29, 2022
@bors bors bot closed this Nov 29, 2022
@bors bors bot deleted the class-expr-no-ident branch November 29, 2022 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working execution Issues or PRs related to code execution parser Issues surrounding the parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants