-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Allow class expressions without identifier #2464
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raskad
added
bug
Something isn't working
parser
Issues surrounding the parser
execution
Issues or PRs related to code execution
labels
Nov 27, 2022
raskad
requested review from
Razican,
jasonwilliams,
HalidOdat,
RageKnify,
jedel1043 and
nekevss
November 27, 2022 03:45
Test262 conformance changes
Fixed tests (44):
Broken tests (4):
|
Codecov Report
@@ Coverage Diff @@
## main #2464 +/- ##
==========================================
+ Coverage 51.04% 51.06% +0.02%
==========================================
Files 345 346 +1
Lines 35963 35954 -9
==========================================
+ Hits 18356 18359 +3
+ Misses 17607 17595 -12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
HalidOdat
approved these changes
Nov 29, 2022
nekevss
approved these changes
Nov 29, 2022
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 29, 2022
This Pull Request changes the following: - Remove false early error when a class expression was missing a binding identifier. - Simplify/fix environment truncation on function returns. The new failed tests where false positives before that will be fixed in another PR.
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Allow class expressions without identifier
[Merged by Bors] - Allow class expressions without identifier
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request changes the following:
The new failed tests where false positives before that will be fixed in another PR.