[Merged by Bors] - Set function names in object literal methods #2460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raskad
added
enhancement
raskad
requested review from
Razican,
jasonwilliams,
HalidOdat,
RageKnify and
jedel1043
Test262 conformance changes
Fixed tests (24): |
Codecov Report
@@ Coverage Diff @@
## main #2460 +/- ##
==========================================
+ Coverage 51.04% 52.01% +0.97%
==========================================
Files 346 343 -3
Lines 35846 35295 -551
==========================================
+ Hits 18297 18359 +62
+ Misses 17549 16936 -613
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
HalidOdat
approved these changes
Nov 25, 2022
boa_engine/src/vm/code_block.rs
Outdated
| @@ -177,7 +177,7 @@ impl CodeBlock { | |||
| let opcode: Opcode = self.code[*pc].try_into().expect("invalid opcode"); | |||
| *pc += size_of::<Opcode>(); | |||
| match opcode { | |||
| Opcode::RotateLeft | Opcode::RotateRight => { | |||
| Opcode::RotateLeft | Opcode::RotateRight | Opcode::SetFunctionName => { | |||
There was a problem hiding this comment.
Suggested change
| Opcode::RotateLeft | Opcode::RotateRight | Opcode::SetFunctionName => { | |
| Opcode::SetFunctionName => { | |
| let operand = self.read::<u8>(*pc); | |
| *pc += size_of::<u8>(); | |
| match operand { | |
| 0 => "prefix: none", | |
| 1 => "prefix: get", | |
| 2 => "prefix: set", | |
| } | |
| } | |
| Opcode::RotateLeft | Opcode::RotateRight => { |
I think it would be good to print the prefix, instead of a number
boa_engine/src/vm/flowgraph/mod.rs
Outdated
| @@ -45,7 +45,7 @@ impl CodeBlock { | |||
|
|
|||
| pc += size_of::<Opcode>(); | |||
| match opcode { | |||
| Opcode::RotateLeft | Opcode::RotateRight => { | |||
| Opcode::RotateLeft | Opcode::RotateRight | Opcode::SetFunctionName => { | |||
There was a problem hiding this comment.
Same here.
Maybe making it a static method of SetFunctionName struct to avoid code duplication.
Razican
approved these changes
Nov 26, 2022
| let value = AssignmentExpression::new(None, true, self.allow_yield, self.allow_await) | ||
| let name = property_name | ||
| .literal() | ||
| .filter(|name| name != &Sym::__PROTO__) |
There was a problem hiding this comment.
Since Sym is Copy, I would suggest to either dereference name, or use copied():
Suggested change
| .filter(|name| name != &Sym::__PROTO__) | |
| .filter(|name| *name != Sym::__PROTO__) |
Even though I guess it's equivalent, it more clearly shows intent of comparing the symbol value, and not the reference.
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 26, 2022
This Pull Request changes the following: - Implement `SetFunctionName` opcode based on [`SetFunctionName`](https://tc39.es/ecma262/#sec-setfunctionname)
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request changes the following:
SetFunctionNameopcode based onSetFunctionName