[Merged by Bors] - Divide byte compiler

[e-codes-stuff]

This Pull Request is currently unfinished but will fix/close #1808 after some review and more work

It changes the following:

• Divides byte compiler logic into separate files

I would like some review on the current code I have to know if the patterns I'm using are acceptable for the codebase, if everything looks good I will try to separate more code into different small modules to finish the work here.

[codecov]

Codecov Report

Merging #2425 (8cd2888) into main (c79b902) will increase coverage by 0.30%.
The diff coverage is 47.53%.

@@            Coverage Diff             @@
##             main    #2425      +/-   ##
==========================================
+ Coverage   52.44%   52.74%   +0.30%     
==========================================
  Files         332      343      +11     
  Lines       34948    34940       -8     
==========================================
+ Hits        18327    18430     +103     
+ Misses      16621    16510     -111     

Impacted Files	Coverage Δ
boa_engine/src/bytecompiler/class.rs	0.00% <0.00%> (ø)
boa_engine/src/bytecompiler/mod.rs	63.79% <ø> (+11.47%)	⬆️
...rc/bytecompiler/declaration/declaration_pattern.rs	26.71% <26.71%> (ø)
...gine/src/bytecompiler/expression/object_literal.rs	42.24% <42.24%> (ø)
boa_engine/src/bytecompiler/expression/mod.rs	51.63% <51.63%> (ø)
boa_engine/src/bytecompiler/expression/assign.rs	64.81% <64.81%> (ø)
boa_engine/src/bytecompiler/statement/continue.rs	70.17% <70.17%> (ø)
boa_engine/src/bytecompiler/statement/loop.rs	74.19% <74.19%> (ø)
boa_engine/src/bytecompiler/statement/mod.rs	78.12% <78.12%> (ø)
boa_engine/src/bytecompiler/expression/binary.rs	81.03% <81.03%> (ø)
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[raskad]

Thanks for starting to work on this!

The current changes look very much the way I would expect.

[RageKnify]

LGTM

[e-codes-stuff]

I went through git rebase --interactive and tried to resolve everything so it can be merged into main, does this seem fine? I'm still not amazing with git so I'm unsure what it should look like in this case.

[nekevss]

The test that's failing is related to Rustfmt. You just need to run cargo fmt 😄

[e-codes-stuff]

Whoops, forgot to run that. Fixed it, anything else?

[raskad]

Thanks for woking on this. I have some suggestions for the new code in general, but I'd be happy to merge this as is and do the changes later.

Instead of the compile* functions being free functions that take byte_compiler: &mut ByteCompiler<'_>, as an argument, I would suggest implementing them on the ByteCompiler.

All of the compile* functions probably could use some minimal documentation, but we do not have any for that right now, so that may wait.

[e-codes-stuff]

Is it possible to implement methods on `ByteCompiler` within submodules? I was under the impression that wasn't allowed which is why I made them free functions, I could pretty easily correct that if theres something I'm missing though

[Razican]

Is it possible to implement methods on ByteCompiler within submodules? I was under the impression that wasn't allowed which is why I made them free functions, I could pretty easily correct that if theres something I'm missing though

It is definitely possible, you just need to create another impl ByteCompiler block. You can have as many of them as you need.

[jasonwilliams]

Agree with @raskad about implementing byteCompiler but apart from that LGTM

[jedel1043]

Thank you for the contribution!

[jedel1043]

bors r+

[bors]

Pull request successfully merged into main.

Build succeeded:

• Build and Test (macos-latest)
• Build and Test (windows-latest)
• Coverage
• Misc