-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Handle __proto__
fields in object literals
#2423
Conversation
Test262 conformance changes
Fixed tests (12):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just have the question about the comma, everything else looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small nitpick. Mostly about documentation of the poco de. We should probably add more references to the spec in general in opcodes.
I'm happy to merge it as is too, though, great work :)
let object = object.as_object().expect("object is not an object"); | ||
object | ||
.__set_prototype_of__(prototype, context) | ||
.expect("cannot fail per spec"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here it says that this cannot fail per the spec, but then I'm missing some link to the spec, or the spec text that says so, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will open is issue for this as it is currently a problem with all opcodes.
Codecov Report
@@ Coverage Diff @@
## main #2423 +/- ##
==========================================
+ Coverage 38.69% 38.86% +0.17%
==========================================
Files 314 316 +2
Lines 23887 24131 +244
==========================================
+ Hits 9242 9378 +136
- Misses 14645 14753 +108
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
bors r+ |
Pull request successfully merged into main. Build succeeded: |
__proto__
fields in object literals__proto__
fields in object literals
This Pull Request changes the following:
__proto__
fields in object literals