[Merged by Bors] - Implement delete for references #2395

jedel1043 · 2022-10-31T05:38:14Z

This Pull Request implements delete for variable references:

x = 5;
console.log(x) // 5;
delete x;
console.log(x) // ReferenceError

It changes the following:

Implements delete for references.
Fixes tests related to deletions of function definitions inside eval.
Implements an op to throw an error on super property deletion.

This puts us at a conformance of 97.98% for the test/language/expressions/delete suite. The last 2 failing tests are related to with statements (11.4.1-4.a-5.js and 11.4.1-4.a-6.js).

github-actions · 2022-10-31T05:45:11Z

Test262 conformance changes

Test result	main count	PR count	difference
Total	93,789	93,789	0
Passed	69,279	69,316	+37
Ignored	18,352	18,352	0
Failed	6,158	6,121	-37
Panics	0	0	0
Conformance	73.87%	73.91%	+0.04%

Fixed tests (37):

test/language/types/reference/S8.7_A5_T2.js (previously Failed)
test/language/eval-code/indirect/var-env-var-init-global-exstng.js [strict mode] (previously Failed)
test/language/eval-code/indirect/var-env-var-init-global-exstng.js (previously Failed)
test/language/eval-code/direct/var-env-var-init-global-exstng.js (previously Failed)
test/language/global-code/S10.4.1_A1_T1.js (previously Failed)
test/language/global-code/decl-func.js [strict mode] (previously Failed)
test/language/global-code/decl-func.js (previously Failed)
test/language/global-code/decl-var.js [strict mode] (previously Failed)
test/language/global-code/decl-var.js (previously Failed)
test/language/global-code/script-decl-var.js [strict mode] (previously Failed)
test/language/global-code/script-decl-var.js (previously Failed)
test/language/statements/variable/S12.2_A2.js (previously Failed)
test/language/expressions/delete/11.4.1-2-2.js [strict mode] (previously Failed)
test/language/expressions/delete/11.4.1-2-2.js (previously Failed)
test/language/expressions/delete/super-property-null-base.js [strict mode] (previously Failed)
test/language/expressions/delete/super-property-null-base.js (previously Failed)
test/language/expressions/delete/11.4.1-3-1.js (previously Failed)
test/language/expressions/delete/S11.4.1_A3.1.js (previously Failed)
test/language/expressions/delete/super-property.js [strict mode] (previously Failed)
test/language/expressions/delete/super-property.js (previously Failed)
test/language/expressions/delete/S11.4.1_A3.2_T1.js (previously Failed)
test/language/expressions/delete/S11.4.1_A3.3_T1.js (previously Failed)
test/language/expressions/delete/11.4.1-4.a-8.js (previously Failed)
test/language/expressions/delete/S11.4.1_A2.2_T1.js (previously Failed)
test/language/expressions/delete/S11.4.1_A3.3_T6.js (previously Failed)
test/language/expressions/delete/super-property-method.js [strict mode] (previously Failed)
test/language/expressions/delete/super-property-method.js (previously Failed)
test/language/expressions/grouping/S11.1.6_A2_T2.js (previously Failed)
test/language/expressions/grouping/S11.1.6_A3_T6.js (previously Failed)
test/annexB/language/global-code/if-decl-else-decl-a-global-init.js (previously Failed)
test/annexB/language/global-code/if-decl-no-else-global-init.js (previously Failed)
test/annexB/language/global-code/if-decl-else-stmt-global-init.js (previously Failed)
test/annexB/language/global-code/switch-case-global-init.js (previously Failed)
test/annexB/language/global-code/switch-dflt-global-init.js (previously Failed)
test/annexB/language/global-code/if-decl-else-decl-b-global-init.js (previously Failed)
test/annexB/language/global-code/block-decl-global-init.js (previously Failed)
test/annexB/language/global-code/if-stmt-else-decl-global-init.js (previously Failed)

codecov · 2022-10-31T05:50:06Z

Codecov Report

Merging #2395 (e610305) into main (bc2dd9c) will decrease coverage by 0.10%.
The diff coverage is 42.22%.

@@            Coverage Diff             @@
##             main    #2395      +/-   ##
==========================================
- Coverage   39.71%   39.61%   -0.11%     
==========================================
  Files         307      307              
  Lines       23437    23507      +70     
==========================================
+ Hits         9309     9313       +4     
- Misses      14128    14194      +66

Impacted Files	Coverage Δ
boa_engine/src/object/internal_methods/global.rs	`22.83% <0.00%> (+0.96%)`	⬆️
boa_engine/src/vm/code_block.rs	`32.56% <ø> (ø)`
boa_engine/src/vm/opcode/await_stm/mod.rs	`0.00% <ø> (ø)`
boa_engine/src/vm/opcode/binary_ops/logical.rs	`100.00% <ø> (ø)`
...a_engine/src/vm/opcode/binary_ops/macro_defined.rs	`100.00% <ø> (ø)`
boa_engine/src/vm/opcode/binary_ops/mod.rs	`85.00% <ø> (ø)`
boa_engine/src/vm/opcode/call/mod.rs	`34.00% <ø> (ø)`
boa_engine/src/vm/opcode/concat/mod.rs	`100.00% <ø> (ø)`
boa_engine/src/vm/opcode/copy/mod.rs	`80.00% <ø> (ø)`
boa_engine/src/vm/opcode/define/class/getter.rs	`0.00% <ø> (ø)`
... and 94 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

raskad

Great work, looks good!

Razican

Looks good, thanks! :) I just had a few questions :)

boa_engine/src/environments/compile.rs

boa_engine/src/vm/opcode/delete/mod.rs

Razican · 2022-10-31T21:26:28Z

bors r+

This Pull Request implements `delete` for variable references: ```Javascript x = 5; console.log(x) // 5; delete x; console.log(x) // ReferenceError ``` It changes the following: - Implements delete for references. - Fixes tests related to deletions of function definitions inside `eval`. - Implements an op to throw an error on super property deletion. This puts us at a conformance of 97.98% for the `test/language/expressions/delete` suite. The last 2 failing tests are related to `with` statements ([11.4.1-4.a-5.js](https://github.com/tc39/test262/blob/b5d3192914e9b107ce4f5df4f77e625865d337c7/test/language/expressions/delete/11.4.1-4.a-5.js#L1) and [11.4.1-4.a-6.js](https://github.com/tc39/test262/blob/b5d3192914e9b107ce4f5df4f77e625865d337c7/test/language/expressions/delete/11.4.1-4.a-6.js#L18)).

bors · 2022-10-31T21:35:54Z

Pull request successfully merged into main.

Build succeeded:

Implement delete for references

a72c5c3

jedel1043 added enhancement New feature or request execution Issues or PRs related to code execution vm Issues and PRs related to the Boa Virtual Machine. labels Oct 31, 2022

jedel1043 added this to the v0.17.0 milestone Oct 31, 2022

jedel1043 requested review from Razican, jasonwilliams, HalidOdat, RageKnify and raskad October 31, 2022 05:38

raskad approved these changes Oct 31, 2022

View reviewed changes

Razican reviewed Oct 31, 2022

View reviewed changes

boa_engine/src/environments/compile.rs Outdated Show resolved Hide resolved

boa_engine/src/vm/opcode/delete/mod.rs Outdated Show resolved Hide resolved

jedel1043 added 2 commits October 31, 2022 10:24

Rename deletable to configurable

fb79789

Remove unnecessary derives for opcodes

e610305

jedel1043 requested a review from Razican October 31, 2022 16:29

Razican approved these changes Oct 31, 2022

View reviewed changes

bors bot changed the title ~~Implement delete for references~~ [Merged by Bors] - Implement delete for references Oct 31, 2022

bors bot closed this Oct 31, 2022

bors bot deleted the ref-delete branch October 31, 2022 21:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Merged by Bors] - Implement delete for references #2395

[Merged by Bors] - Implement delete for references #2395

jedel1043 commented Oct 31, 2022 •

edited

Loading

github-actions bot commented Oct 31, 2022

codecov bot commented Oct 31, 2022 •

edited

Loading

raskad left a comment

Razican left a comment

Razican commented Oct 31, 2022

bors bot commented Oct 31, 2022

[Merged by Bors] - Implement delete for references #2395

[Merged by Bors] - Implement delete for references #2395

Conversation

jedel1043 commented Oct 31, 2022 • edited Loading

github-actions bot commented Oct 31, 2022

Test262 conformance changes

codecov bot commented Oct 31, 2022 • edited Loading

Codecov Report

raskad left a comment

Choose a reason for hiding this comment

Razican left a comment

Choose a reason for hiding this comment

Razican commented Oct 31, 2022

bors bot commented Oct 31, 2022

jedel1043 commented Oct 31, 2022 •

edited

Loading

codecov bot commented Oct 31, 2022 •

edited

Loading