Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Generate Opcode impl using macro #2391

Closed
wants to merge 1 commit into from

Conversation

jedel1043
Copy link
Member

This reduces a lot of the repetition from the Opcode functions and makes it easier to add a new Op.

@jedel1043 jedel1043 added the Internal Category for changelog label Oct 29, 2022
@jedel1043 jedel1043 added this to the v0.17.0 milestone Oct 29, 2022
@github-actions
Copy link

github-actions bot commented Oct 29, 2022

Test262 conformance changes

Test result main count PR count difference
Total 93,789 93,789 0
Passed 69,271 69,271 0
Ignored 18,352 18,352 0
Failed 6,166 6,166 0
Panics 0 0 0
Conformance 73.86% 73.86% 0.00%

@codecov
Copy link

codecov bot commented Oct 29, 2022

Codecov Report

Merging #2391 (f5d090a) into main (4b892a9) will decrease coverage by 0.21%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main    #2391      +/-   ##
==========================================
- Coverage   39.81%   39.59%   -0.22%     
==========================================
  Files         307      307              
  Lines       23547    23394     -153     
==========================================
- Hits         9375     9264     -111     
+ Misses      14172    14130      -42     
Impacted Files Coverage Δ
boa_engine/src/vm/opcode/mod.rs 66.66% <71.42%> (+16.66%) ⬆️
boa_engine/src/vm/mod.rs 42.85% <100.00%> (-13.35%) ⬇️
boa_engine/src/vm/call_frame.rs 50.00% <0.00%> (-10.00%) ⬇️
boa_engine/src/syntax/ast/statement/block.rs 35.29% <0.00%> (-5.89%) ⬇️
.../src/syntax/ast/statement/iteration/for_of_loop.rs 39.13% <0.00%> (-4.35%) ⬇️
.../src/syntax/ast/statement/iteration/for_in_loop.rs 34.78% <0.00%> (-4.35%) ⬇️
boa_engine/src/syntax/ast/declaration/mod.rs 75.75% <0.00%> (-3.04%) ⬇️
boa_engine/src/builtins/map/map_iterator.rs 91.42% <0.00%> (-2.69%) ⬇️
boa_engine/src/syntax/ast/statement/try/mod.rs 41.81% <0.00%> (-1.82%) ⬇️
boa_engine/src/vm/opcode/set/name.rs 63.63% <0.00%> (-1.59%) ⬇️
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change!

Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change! Hopefully it won't add much compile time :)

@jedel1043
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Oct 29, 2022
This reduces a lot of the repetition from the `Opcode` functions and makes it easier to add a new Op.
@bors
Copy link

bors bot commented Oct 29, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Generate Opcode impl using macro [Merged by Bors] - Generate Opcode impl using macro Oct 29, 2022
@bors bors bot closed this Oct 29, 2022
@bors bors bot deleted the opcode_macro branch October 29, 2022 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Category for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants