Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Add named evaluation of logical assignments #2389

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Add named evaluation of logical assignments #2389

wants to merge 1 commit into from

Conversation

raskad
Copy link
Member

@raskad raskad commented Oct 26, 2022

This Pull Request changes the following:

  • Add named evaluation of logical assignments

@raskad raskad added enhancement New feature or request parser Issues surrounding the parser execution Issues or PRs related to code execution labels Oct 26, 2022
@raskad raskad added this to the v0.17.0 milestone Oct 26, 2022
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 93,789 93,789 0
Passed 69,181 69,199 +18
Ignored 18,352 18,352 0
Failed 6,256 6,238 -18
Panics 0 0 0
Conformance 73.76% 73.78% +0.02%
Fixed tests (18): 
test/language/expressions/logical-assignment/lgcl-or-assignment-operator-namedevaluation-function.js [strict mode] (previously Failed)
test/language/expressions/logical-assignment/lgcl-or-assignment-operator-namedevaluation-function.js (previously Failed)
test/language/expressions/logical-assignment/lgcl-nullish-assignment-operator-namedevaluation-arrow-function.js [strict mode] (previously Failed)
test/language/expressions/logical-assignment/lgcl-nullish-assignment-operator-namedevaluation-arrow-function.js (previously Failed)
test/language/expressions/logical-assignment/lgcl-and-assignment-operator-namedevaluation-function.js [strict mode] (previously Failed)
test/language/expressions/logical-assignment/lgcl-and-assignment-operator-namedevaluation-function.js (previously Failed)
test/language/expressions/logical-assignment/lgcl-nullish-assignment-operator-namedevaluation-function.js [strict mode] (previously Failed)
test/language/expressions/logical-assignment/lgcl-nullish-assignment-operator-namedevaluation-function.js (previously Failed)
test/language/expressions/logical-assignment/lgcl-or-assignment-operator-namedevaluation-class-expression.js [strict mode] (previously Failed)
test/language/expressions/logical-assignment/lgcl-or-assignment-operator-namedevaluation-class-expression.js (previously Failed)
test/language/expressions/logical-assignment/lgcl-or-assignment-operator-namedevaluation-arrow-function.js [strict mode] (previously Failed)
test/language/expressions/logical-assignment/lgcl-or-assignment-operator-namedevaluation-arrow-function.js (previously Failed)
test/language/expressions/logical-assignment/lgcl-and-assignment-operator-namedevaluation-arrow-function.js [strict mode] (previously Failed)
test/language/expressions/logical-assignment/lgcl-and-assignment-operator-namedevaluation-arrow-function.js (previously Failed)
test/language/expressions/logical-assignment/lgcl-and-assignment-operator-namedevaluation-class-expression.js [strict mode] (previously Failed)
test/language/expressions/logical-assignment/lgcl-and-assignment-operator-namedevaluation-class-expression.js (previously Failed)
test/language/expressions/logical-assignment/lgcl-nullish-assignment-operator-namedevaluation-class-expression.js [strict mode] (previously Failed)
test/language/expressions/logical-assignment/lgcl-nullish-assignment-operator-namedevaluation-class-expression.js (previously Failed)

jedel1043
jedel1043 approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such weird corner case! Nice catch

Razican
Razican approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one!

@Razican
Copy link
Member

Razican commented Oct 26, 2022

bors r+

bors bot pushed a commit that referenced this pull request Oct 26, 2022
@raskad
Add named evaluation of logical assignments (#2389)
b67596b 
This Pull Request changes the following:

- Add named evaluation of logical assignments
@bors
Copy link

bors bot commented Oct 26, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Add named evaluation of logical assignments [Merged by Bors] - Add named evaluation of logical assignments Oct 26, 2022
@bors bors bot closed this Oct 26, 2022
@bors bors bot deleted the named-eval-in-assignment-ops branch October 26, 2022 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedel1043 jedel1043 jedel1043 approved these changes

@Razican Razican Razican approved these changes

@jasonwilliams jasonwilliams Awaiting requested review from jasonwilliams

@HalidOdat HalidOdat Awaiting requested review from HalidOdat

@RageKnify RageKnify Awaiting requested review from RageKnify

Assignees
No one assigned
Labels
enhancement New feature or request execution Issues or PRs related to code execution parser Issues surrounding the parser
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.
3 participants
@raskad @Razican @jedel1043