-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Implement member accessors in initializer of for loops #2381
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedel1043
added
enhancement
New feature or request
vm
Issues and PRs related to the Boa Virtual Machine.
ast
Issue surrounding the abstract syntax tree
labels
Oct 26, 2022
jedel1043
requested review from
Razican,
jasonwilliams,
HalidOdat,
RageKnify and
raskad
October 26, 2022 01:01
jedel1043
changed the title
Implement member accessors on for loops
Implement member accessors in initializer of for loops
Oct 26, 2022
Test262 conformance changes
Fixed tests (26):
|
Codecov Report
@@ Coverage Diff @@
## main #2381 +/- ##
==========================================
+ Coverage 39.88% 39.93% +0.04%
==========================================
Files 304 304
Lines 23317 23308 -9
==========================================
+ Hits 9300 9307 +7
+ Misses 14017 14001 -16
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
raskad
approved these changes
Oct 26, 2022
HalidOdat
approved these changes
Oct 26, 2022
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 26, 2022
This Pull Request implements member accessors in `for ... in` and `for ... of` loops. This unlocks patterns like: ```Javascript let obj = {a: 0, b: 1}; for (obj.a of [1,2,3]) { } console.log(obj.a) // 3 ```
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Implement member accessors in initializer of for loops
[Merged by Bors] - Implement member accessors in initializer of for loops
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ast
Issue surrounding the abstract syntax tree
enhancement
New feature or request
vm
Issues and PRs related to the Boa Virtual Machine.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request implements member accessors in
for ... in
andfor ... of
loops. This unlocks patterns like: