-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Document the AST #2377
Conversation
Test262 conformance changes
|
Codecov Report
@@ Coverage Diff @@
## main #2377 +/- ##
==========================================
- Coverage 39.89% 39.88% -0.01%
==========================================
Files 304 304
Lines 23332 23317 -15
==========================================
- Hits 9308 9300 -8
+ Misses 14024 14017 -7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very good work!! Thank you so much.
I have added some comments, let me know what you think :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks perfect to me! :)
Bors r+ |
🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
bors r+ |
As promised in #2319 (comment). There are still some style inconsistencies (which require a bit more time and effort), but having the whole module documented is a lot better for clarity.
Pull request successfully merged into main. Build succeeded: |
As promised in #2319 (comment). There are still some style inconsistencies (which require a bit more time and effort), but having the whole module documented is a lot better for clarity.