Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Implement LabelledStatement #2349

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - Implement LabelledStatement #2349

wants to merge 6 commits into from

Conversation

jedel1043
Copy link
Member

@jedel1043 jedel1043 commented Oct 17, 2022 •
edited by Razican
Loading

This Pull Request changes the following:

  • Implements the LabelledStatement Parse node.
  • Removes label from all label-able items (switch, blocks and loop statements).
  • Adjusts parsing to the new AST.

#2295 isn't fixed by this, but with this change it should be easier to fix.

@jedel1043 jedel1043 added parser Issues surrounding the parser ast Issue surrounding the abstract syntax tree labels Oct 17, 2022
@jedel1043 jedel1043 added this to the v0.17.0 milestone Oct 17, 2022
@github-actions
Copy link

github-actions bot commented Oct 17, 2022 •
edited
Loading

Test262 conformance changes

Test result main count PR count difference
Total 93,383 93,383 0
Passed 69,095 69,096 +1
Ignored 18,182 18,182 0
Failed 6,106 6,105 -1
Panics 0 0 0
Conformance 73.99% 73.99% +0.00%
Fixed tests (1): 
test/annexB/language/statements/labeled/function-declaration.js (previously Failed)

@codecov
Copy link

codecov bot commented Oct 17, 2022 •
edited
Loading

Codecov Report

Merging #2349 (23ee311) into main (959b9f1) will decrease coverage by 0.25%.
The diff coverage is 51.07%.

@@            Coverage Diff             @@
##             main    #2349      +/-   ##
==========================================
- Coverage   40.14%   39.88%   -0.26%     
==========================================
  Files         241      243       +2     
  Lines       22966    23286     +320     
==========================================
+ Hits         9219     9288      +69     
- Misses      13747    13998     +251
Impacted Files Coverage Δ
boa_engine/src/syntax/ast/statement/block.rs 37.50% <ø> (+4.16%) ⬆️
...ine/src/syntax/ast/statement/iteration/for_loop.rs 44.44% <ø> (-1.46%) ⬇️
boa_engine/src/syntax/ast/statement/return.rs 36.36% <0.00%> (ø)
boa_engine/src/syntax/ast/statement_list/mod.rs 65.45% <ø> (-0.62%) ⬇️
boa_engine/src/syntax/parser/error.rs 42.22% <0.00%> (-0.96%) ⬇️
...tax/parser/expression/assignment/arrow_function.rs 31.50% <ø> (+0.42%) ⬆️
...a_engine/src/syntax/parser/statement/if_stm/mod.rs 33.92% <38.88%> (+2.55%) ⬆️
...ntax/parser/statement/iteration/while_statement.rs 52.63% <40.00%> (-4.52%) ⬇️
boa_engine/src/syntax/ast/statement/labelled.rs 43.75% <43.75%> (ø)
...rc/syntax/ast/statement/iteration/do_while_loop.rs 50.00% <50.00%> (+4.54%) ⬆️
... and 88 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jedel1043 jedel1043 requested a review from Razican October 21, 2022 18:54
Razican
Razican approved these changes Oct 22, 2022
View reviewed changes
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

raskad
raskad approved these changes Oct 22, 2022
View reviewed changes
Copy link
Member

@raskad raskad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@raskad
Copy link
Member

raskad commented Oct 22, 2022

bors r+

bors bot pushed a commit that referenced this pull request Oct 22, 2022
@jedel1043
Implement LabelledStatement (#2349)
d4c220a 
This Pull Request changes the following:

- Implements the `LabelledStatement` Parse node.
- Removes `label` from all label-able items (switch, blocks and loop statements).
- Adjusts parsing to the new AST.

#2295 isn't fixed by this, but with this change it should be easier to fix.
@bors
Copy link

bors bot commented Oct 22, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Implement LabelledStatement [Merged by Bors] - Implement LabelledStatement Oct 22, 2022
@bors bors bot closed this Oct 22, 2022
@bors bors bot deleted the labelled-stmt branch October 22, 2022 12:51
@Razican Razican added the hacktoberfest-accepted PR accepted for Hacktoberfest label Oct 22, 2022
@RageKnify RageKnify added the Internal Category for changelog label Nov 9, 2022
@RageKnify RageKnify added enhancement New feature or request and removed Internal Category for changelog labels Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raskad raskad raskad approved these changes

@RageKnify RageKnify RageKnify approved these changes

@Razican Razican Razican approved these changes

@jasonwilliams jasonwilliams Awaiting requested review from jasonwilliams

@HalidOdat HalidOdat Awaiting requested review from HalidOdat

Assignees
No one assigned
Labels
ast Issue surrounding the abstract syntax tree enhancement New feature or request hacktoberfest-accepted PR accepted for Hacktoberfest parser Issues surrounding the parser
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jedel1043 @raskad @Razican @RageKnify