[Merged by Bors] - Upgrade clap to 4.0, add value hints for zsh and fish #2336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Razican
added
enhancement
Razican
requested review from
jasonwilliams,
HalidOdat,
RageKnify,
raskad and
jedel1043
Codecov Report
@@ Coverage Diff @@
## main #2336 +/- ##
==========================================
- Coverage 40.82% 40.79% -0.03%
==========================================
Files 240 240
Lines 22743 22742 -1
==========================================
- Hits 9285 9278 -7
- Misses 13458 13464 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jedel1043
approved these changes
Oct 10, 2022
|
Huh, the update probably changed some syntax of the |
Should be fixed now :) |
Test262 conformance changesVM implementation
|
jasonwilliams
approved these changes
Oct 15, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 15, 2022
This Pull Request fixes/closes #2330. It changes the following: - Upgrades from clap 3 to clap 4 (note that criterion still uses clap 3, tracked here: bheisler/criterion.rs#596) - Updates the derive syntax with the new 4.0 syntax - Adds hints for fish & zsh Co-authored-by: José Julián Espina <[email protected]>
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #2330.
It changes the following: