Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Fix Regex literal parsing in MemberExpression #2328

Closed
wants to merge 8 commits into from
Closed

[Merged by Bors] - Fix Regex literal parsing in MemberExpression #2328

wants to merge 8 commits into from
+61 −2

Conversation

tunz
Copy link
Contributor

@tunz tunz commented Oct 10, 2022

This Pull Request fixes/closes #2327

It changes the following:

  • set_goal(RegExp) for PrimaryExpression parsing

@codecov
Copy link

codecov bot commented Oct 10, 2022 •
edited
Loading

Codecov Report

Merging #2328 (c93caef) into main (a47d9ec) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2328      +/-   ##
==========================================
- Coverage   39.85%   39.85%   -0.01%     
==========================================
  Files         242      242              
  Lines       23244    23247       +3     
==========================================
+ Hits         9263     9264       +1     
- Misses      13981    13983       +2
Impacted Files Coverage Δ
...ntax/parser/expression/left_hand_side/arguments.rs 36.58% <0.00%> (+1.58%) ⬆️
.../syntax/parser/expression/left_hand_side/member.rs 32.74% <0.00%> (-0.59%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Razican
Copy link
Member

Razican commented Oct 21, 2022

Test262 conformance changes

VM implementation

Test result main count PR count difference
Total 92,399 92,399 0
Passed 68,926 68,932 +6
Ignored 17,228 17,228 0
Failed 6,245 6,239 -6
Panics 0 0 0
Conformance 74.60% 74.60% +0.01%
Fixed tests (6): 
test/language/expressions/division/S11.5.2_A2.2_T1.js [strict mode] (previously Failed)
test/language/expressions/division/S11.5.2_A2.2_T1.js (previously Failed)
test/language/expressions/division/S11.5.2_A3_T1.5.js [strict mode] (previously Failed)
test/language/expressions/division/S11.5.2_A3_T1.5.js (previously Failed)
test/language/expressions/division/bigint-toprimitive.js [strict mode] (previously Failed)
test/language/expressions/division/bigint-toprimitive.js (previously Failed)

@Razican Razican added this to the v0.17.0 milestone Oct 21, 2022
@Razican Razican added bug Something isn't working parser Issues surrounding the parser labels Oct 21, 2022
Razican
Razican reviewed Oct 21, 2022
View reviewed changes
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay in the review! It looks great. Would it be possible to add a Rust test for this?

@RageKnify RageKnify requested a review from Razican October 22, 2022 11:03
Razican
Razican approved these changes Oct 22, 2022
View reviewed changes
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM :)

@Razican
Copy link
Member

Razican commented Oct 22, 2022

bors r+

bors bot pushed a commit that referenced this pull request Oct 22, 2022
@tunz
Fix Regex literal parsing in MemberExpression (#2328)
904e422 
This Pull Request fixes/closes #2327 

It changes the following:
- set_goal(RegExp) for PrimaryExpression parsing
@bors
Copy link

bors bot commented Oct 22, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix Regex literal parsing in MemberExpression [Merged by Bors] - Fix Regex literal parsing in MemberExpression Oct 22, 2022
@bors bors bot closed this Oct 22, 2022
@tunz tunz deleted the tunz/fix-regex-literal-call-args branch July 18, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RageKnify RageKnify RageKnify approved these changes

@Razican Razican Razican approved these changes

@raskad raskad Awaiting requested review from raskad

@HalidOdat HalidOdat Awaiting requested review from HalidOdat

@jasonwilliams jasonwilliams Awaiting requested review from jasonwilliams

@jedel1043 jedel1043 Awaiting requested review from jedel1043

Assignees
No one assigned
Labels
bug Something isn't working parser Issues surrounding the parser
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.

syntax error of /=/ when it's used in call expression arguments
3 participants
@tunz @Razican @RageKnify