-
-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Fixing the output for the test diffs in PRs #2320
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Razican
added
bug
Something isn't working
test
Issues and PRs related to the tests.
labels
Oct 2, 2022
Razican
requested review from
jasonwilliams,
HalidOdat,
RageKnify,
raskad and
jedel1043
October 2, 2022 10:50
Test262 conformance changesVM implementation
|
Codecov Report
@@ Coverage Diff @@
## main #2320 +/- ##
=======================================
Coverage 41.14% 41.14%
=======================================
Files 237 237
Lines 22393 22393
=======================================
Hits 9213 9213
Misses 13180 13180 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
RageKnify
suggested changes
Oct 2, 2022
jedel1043
approved these changes
Oct 2, 2022
RageKnify
approved these changes
Oct 4, 2022
RageKnify
approved these changes
Oct 4, 2022
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 4, 2022
This PR fixes PR comments where negative numbers from 100 to 999 would be shown as `-,999` instead of `-999`
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Fixing the output for the test diffs in PRs
[Merged by Bors] - Fixing the output for the test diffs in PRs
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
hacktoberfest-accepted
PR accepted for Hacktoberfest
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes PR comments where negative numbers from 100 to 999 would be shown as
-,999
instead of-999