Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Add unicode terminator to line comment #2301

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - Add unicode terminator to line comment #2301

wants to merge 3 commits into from

Conversation

creampnx-x
Copy link
Contributor

This PR sloves the unicode terminator to single line comment

@creampnx-x creampnx-x marked this pull request as draft September 24, 2022 07:32
@codecov
Copy link

codecov bot commented Sep 24, 2022 •
edited
Loading

Codecov Report

Merging #2301 (a70520f) into main (77e739c) will increase coverage by 0.02%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #2301      +/-   ##
==========================================
+ Coverage   41.23%   41.25%   +0.02%     
==========================================
  Files         237      237              
  Lines       22342    22347       +5     
==========================================
+ Hits         9212     9219       +7     
+ Misses      13130    13128       -2
Impacted Files Coverage Δ
boa_engine/src/syntax/lexer/comment.rs 53.84% <50.00%> (-2.92%) ⬇️
boa_engine/src/syntax/ast/node/spread/mod.rs 57.14% <0.00%> (-14.29%) ⬇️
...parser/expression/primary/array_initializer/mod.rs 38.88% <0.00%> (-1.86%) ⬇️
boa_engine/src/context/mod.rs 30.73% <0.00%> (-0.44%) ⬇️
boa_engine/src/object/internal_methods/array.rs 77.77% <0.00%> (-0.41%) ⬇️
boa_engine/src/builtins/object/mod.rs 56.39% <0.00%> (-0.17%) ⬇️
boa_engine/src/builtins/function/mod.rs 24.10% <0.00%> (-0.13%) ⬇️
boa_engine/src/builtins/typed_array/mod.rs 3.76% <0.00%> (-0.01%) ⬇️
boa_engine/src/builtins/array/mod.rs 74.92% <0.00%> (+0.04%) ⬆️
boa_engine/src/vm/mod.rs 45.94% <0.00%> (+0.05%) ⬆️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@creampnx-x creampnx-x marked this pull request as ready for review September 24, 2022 08:41
@creampnx-x
Copy link
Contributor Author

Test262 conformance changes

VM implementation

Test result main count PR count difference
Total 92,057 92,057 0
Passed 68,612 68,622 +10
Ignored 16,832 16,832 0
Failed 6,613 6,603 -10
Panics 0 0 0
Conformance 74.53% 74.54% +0.01%
Fixed tests (10): 
test/language/line-terminators/comment-single-ps.js [strict mode] (previously Failed)
test/language/line-terminators/comment-single-ps.js (previously Failed)
test/language/line-terminators/comment-single-ls.js [strict mode] (previously Failed)
test/language/line-terminators/comment-single-ls.js (previously Failed)
test/language/line-terminators/invalid-comment-single-ls.js [strict mode] (previously Failed)
test/language/line-terminators/invalid-comment-single-ls.js (previously Failed)
test/language/line-terminators/invalid-comment-single-ps.js [strict mode] (previously Failed)
test/language/line-terminators/invalid-comment-single-ps.js (previously Failed)
test/language/comments/S7.4_A5.js [strict mode] (previously Failed)
test/language/comments/S7.4_A5.js (previously Failed)

@raskad raskad added this to the v0.17.0 milestone Sep 24, 2022
@raskad raskad added bug Something isn't working lexer Issues surrounding the lexer labels Sep 24, 2022
raskad
raskad approved these changes Sep 24, 2022
View reviewed changes
Copy link
Member

@raskad raskad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix, thanks!

Razican
Razican approved these changes Sep 24, 2022
View reviewed changes
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@raskad raskad changed the title small fix: add unicode terminator to line comment. Add unicode terminator to line comment Sep 25, 2022
@raskad
Copy link
Member

raskad commented Sep 25, 2022

bors r+

bors bot pushed a commit that referenced this pull request Sep 25, 2022
@creampnx-x
Add unicode terminator to line comment (#2301)
573ac14 
This PR sloves the unicode terminator to single line comment
+ [{u+2028}](https://unicode-table.com/en/2028/)
+ [{u+2029}](https://unicode-table.com/en/2029/)
+ [related test](https://github.com/tc39/test262/blob/9215420deee3e5887d29f95822bf6a474c1bf728/test/language/line-terminators/comment-single-ps.js)
+ [related test set](https://github.com/tc39/test262/tree/9215420deee3e5887d29f95822bf6a474c1bf728/test/language/line-terminators)


Co-authored-by: creampnx_x <[email protected]>
@bors
Copy link

bors bot commented Sep 25, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Add unicode terminator to line comment [Merged by Bors] - Add unicode terminator to line comment Sep 25, 2022
@bors bors bot closed this Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raskad raskad raskad approved these changes

@Razican Razican Razican approved these changes

@HalidOdat HalidOdat Awaiting requested review from HalidOdat

@jasonwilliams jasonwilliams Awaiting requested review from jasonwilliams

@jedel1043 jedel1043 Awaiting requested review from jedel1043

@RageKnify RageKnify Awaiting requested review from RageKnify

Assignees
No one assigned
Labels
bug Something isn't working lexer Issues surrounding the lexer
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.
3 participants
@creampnx-x @raskad @Razican