Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Implement for await...of loops #2286

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Implement for await...of loops #2286

wants to merge 1 commit into from

Conversation

raskad
Copy link
Member

@raskad raskad commented Sep 18, 2022

This Pull Request changes the following:

  • Implement for await...of loop parsing
  • Implement for await...of execution

@raskad raskad added enhancement New feature or request parser Issues surrounding the parser execution Issues or PRs related to code execution labels Sep 18, 2022
@raskad raskad added this to the v0.17.0 milestone Sep 18, 2022
@raskad
Copy link
Member Author

raskad commented Sep 18, 2022

VM implementation

Test result main count PR count difference
Total 91,827 91,827 0
Passed 65,916 68,189 +2,273
Ignored 16,672 16,672 0
Failed 9,239 6,966 -2,273
Panics 0 0 0
Conformance 71.78% 74.26% +2.48%

@codecov
Copy link

codecov bot commented Sep 18, 2022

Codecov Report

Merging #2286 (4e4172a) into main (09e35a8) will decrease coverage by 0.06%.
The diff coverage is 15.09%.

@@            Coverage Diff             @@
##             main    #2286      +/-   ##
==========================================
- Coverage   41.58%   41.52%   -0.07%     
==========================================
  Files         235      235              
  Lines       22093    22140      +47     
==========================================
+ Hits         9188     9193       +5     
- Misses      12905    12947      +42
Impacted Files Coverage Δ
boa_engine/src/builtins/iterable/mod.rs 48.48% <0.00%> (-0.38%) ⬇️
boa_engine/src/vm/code_block.rs 32.63% <ø> (ø)
boa_engine/src/vm/mod.rs 46.06% <0.00%> (-0.85%) ⬇️
boa_engine/src/vm/opcode.rs 50.00% <ø> (ø)
...syntax/parser/statement/iteration/for_statement.rs 34.67% <15.78%> (-2.49%) ⬇️
boa_engine/src/bytecompiler/mod.rs 29.22% <33.33%> (+0.04%) ⬆️
...e/src/syntax/ast/node/iteration/for_of_loop/mod.rs 64.00% <66.66%> (-1.22%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

jedel1043
jedel1043 approved these changes Sep 18, 2022
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Razican
Razican approved these changes Sep 19, 2022
View reviewed changes
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! And incredible improvement in tests for around 120 new lines :) thank you!

I think this could go in 0.16, feel free to change the milestone and merge it.

@jedel1043 jedel1043 modified the milestones: v0.17.0, v0.16.0 Sep 19, 2022
@jedel1043
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Sep 19, 2022
@raskad
Implement for await...of loops (#2286)
d286339 
This Pull Request changes the following:

- Implement `for await...of` loop parsing
- Implement `for await...of` execution
@bors
Copy link

bors bot commented Sep 19, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Implement for await...of loops [Merged by Bors] - Implement for await...of loops Sep 19, 2022
@bors bors bot closed this Sep 19, 2022
@bors bors bot deleted the for-await branch September 19, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedel1043 jedel1043 jedel1043 approved these changes

@Razican Razican Razican approved these changes

@jasonwilliams jasonwilliams Awaiting requested review from jasonwilliams

@HalidOdat HalidOdat Awaiting requested review from HalidOdat

@RageKnify RageKnify Awaiting requested review from RageKnify

Assignees
No one assigned
Labels
enhancement New feature or request execution Issues or PRs related to code execution parser Issues surrounding the parser
Projects
None yet
Milestone
v0.16.0
Development

Successfully merging this pull request may close these issues.
3 participants
@raskad @jedel1043 @Razican