[Merged by Bors] - Create new lazy Error type #2283
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedel1043
added
enhancement
jedel1043
requested review from
Razican,
jasonwilliams,
HalidOdat,
RageKnify and
raskad
Test262 conformance changesVM implementation
Fixed tests (4):Broken tests (4): |
Codecov Report
@@ Coverage Diff @@
## main #2283 +/- ##
==========================================
- Coverage 40.14% 39.84% -0.31%
==========================================
Files 241 242 +1
Lines 22966 23242 +276
==========================================
+ Hits 9219 9260 +41
- Misses 13747 13982 +235
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Benchmark for 1b283bdClick to view benchmark
|
jedel1043
force-pushed
the
new_error
branch
from
4d84f7d to
6a84f78
Compare
Benchmark for 75cf117Click to view benchmark
|
Benchmark for be6f36dClick to view benchmark
|
Benchmark for f7ecaa4Click to view benchmark
|
Benchmark for 761a735Click to view benchmark
|
jedel1043
force-pushed
the
new_error
branch
from
8afcc6b to
faac2f4
Compare
|
Finished documenting and adding examples. Let me know if I overlooked something :) |
Benchmark for 60b54c3Click to view benchmark
|
Benchmark for 36078ecClick to view benchmark
|
jedel1043
force-pushed
the
new_error
branch
from
f558bac to
5522db4
Compare
Benchmark for 27963bfClick to view benchmark
|
jedel1043
force-pushed
the
new_error
branch
from
5522db4 to
9b53af3
Compare
Benchmark for 607203eClick to view benchmark
|
jedel1043
force-pushed
the
new_error
branch
2 times, most recently
from
d99df0d to
0ebf10d
Compare
Benchmark for 61aec7eClick to view benchmark
|
Benchmark for 83de1d4Click to view benchmark
|
Razican
approved these changes
Oct 10, 2022
Benchmark for 95b6f47Click to view benchmark
|
Benchmark for cbbdae0Click to view benchmark
|
Fix detection of Test262Error in boa_tester cargo update
Add doc examples Remove unnecessary whitespace in example
Benchmark for 8339f70Click to view benchmark
|
Benchmark for 6beb20cClick to view benchmark
|
RageKnify
reviewed
Oct 19, 2022
RageKnify
approved these changes
Oct 19, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 19, 2022
This is an experiment that tries to migrate the codebase from eager `Error` objects to lazy ones. In short words, this redefines `JsResult = Result<JsValue, JsError>`, where `JsError` is a brand new type that stores only the essential part of an error type, and only transforms those errors to `JsObject`s on demand (when having to pass them as arguments to functions or store them inside async/generators). This change is pretty big, because it unblocks a LOT of code from having to take a `&mut Context` on each call. It also paves the road for possibly making `JsError` a proper variant of `JsValue`, which can be a pretty big optimization for try/catch. A downside of this is that it exposes some brand new error types to our public API. However, we can now implement `Error` on `JsError`, making our `JsResult` type a bit more inline with Rust's best practices. ~Will mark this as draft, since it's missing some documentation and a lot of examples, but~ it's pretty much feature complete. As always, any comments about the design are very much appreciated! Note: Since there are a lot of changes which are essentially just rewriting `context.throw` to `JsNativeError::%type%`, I'll leave an "index" of the most important changes here: - [boa_engine/src/error.rs](https://github.com/boa-dev/boa/pull/2283/files#diff-f15f2715655440626eefda5c46193d29856f4949ad37380c129a8debc6b82f26) - [boa_engine/src/builtins/error/mod.rs](https://github.com/boa-dev/boa/pull/2283/files#diff-3eb1e4b4b5c7210eb98192a5277f5a239148423c6b970c4ae05d1b267f8f1084) - [boa_tester/src/exec/mod.rs](https://github.com/boa-dev/boa/pull/2283/files#diff-fc3d7ad7b5e64574258c9febbe56171f3309b74e0c8da35238a76002f3ee34d9)
Benchmark for d9361d9Click to view benchmark
|
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experiment that tries to migrate the codebase from eager
Errorobjects to lazy ones.In short words, this redefines
JsResult = Result<JsValue, JsError>, whereJsErroris a brand new type that stores only the essential part of an error type, and only transforms those errors toJsObjects on demand (when having to pass them as arguments to functions or store them inside async/generators).This change is pretty big, because it unblocks a LOT of code from having to take a
&mut Contexton each call. It also paves the road for possibly makingJsErrora proper variant ofJsValue, which can be a pretty big optimization for try/catch.A downside of this is that it exposes some brand new error types to our public API. However, we can now implement
ErroronJsError, making ourJsResulttype a bit more inline with Rust's best practices.Will mark this as draft, since it's missing some documentation and a lot of examples, butit's pretty much feature complete. As always, any comments about the design are very much appreciated!Note: Since there are a lot of changes which are essentially just rewriting
context.throwtoJsNativeError::%type%, I'll leave an "index" of the most important changes here: