-
-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Implement Async-from-Sync Iterator Objects #2234
Conversation
Test262 conformance changesVM implementation
Fixed tests (972):
|
Codecov Report
@@ Coverage Diff @@
## main #2234 +/- ##
==========================================
- Coverage 41.33% 41.23% -0.11%
==========================================
Files 234 235 +1
Lines 22019 22107 +88
==========================================
+ Hits 9101 9115 +14
- Misses 12918 12992 +74
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
584ba0e
to
719c4b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good! Sorry for not reviewing this earlier.
I only found a couple of potential changes that might make sense: a name that was changed from the spec, and some comments that are probably too wide in a single line (Rust formatting conventions prefer lines with less than 100 characters).
But I would be happy to merge it like this too, great work!!!
719c4b4
to
bdaf769
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
let value_wrapper = Promise::promise_resolve( | ||
context.intrinsics().constructors().promise().constructor(), | ||
value, | ||
context, | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to do a complete survey of the strictness of our return types, because apparently promise_resolve
only returns JsObjects
but has a return type of JsValue
, and that would save us an expect
.
bors r+ |
This Pull Request changes the following: - Implement [Async-from-Sync Iterator Objects](https://tc39.es/ecma262/#sec-async-from-sync-iterator-objects) - Give the proper `async` hint to `GetIterator` when executing a delegate yield expression in an async generator function
Pull request successfully merged into main. Build succeeded:
|
This Pull Request changes the following:
async
hint toGetIterator
when executing a delegate yield expression in an async generator function