Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fix arguments object iterator function #2231

Closed
wants to merge 1 commit into from

Conversation

raskad
Copy link
Member

@raskad raskad commented Aug 12, 2022

This Pull Request changes the following:

  • Create the %Array.prototype.values% function object once and use it in both the Array prototype and as the @@iterator value of arguments objects.

This fixes a test where arguments[Symbol.iterator] and [][Symbol.iterator] would not be equal.

@raskad raskad added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics labels Aug 12, 2022
@raskad raskad added this to the v0.16.0 milestone Aug 12, 2022
@github-actions
Copy link

Test262 conformance changes

VM implementation

Test result main count PR count difference
Total 91,573 91,573 0
Passed 59,820 59,822 +2
Ignored 14,606 14,606 0
Failed 17,147 17,145 -2
Panics 0 0 0
Conformance 65.32% 65.33% +0.00%
Fixed tests (2):
test/language/arguments-object/mapped/Symbol.iterator.js (previously Failed)
test/language/arguments-object/unmapped/Symbol.iterator.js (previously Failed)

@codecov
Copy link

codecov bot commented Aug 12, 2022

Codecov Report

Merging #2231 (6f0c6e2) into main (a8bf59d) will increase coverage by 0.01%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main    #2231      +/-   ##
==========================================
+ Coverage   41.99%   42.00%   +0.01%     
==========================================
  Files         231      231              
  Lines       21530    21536       +6     
==========================================
+ Hits         9042     9047       +5     
- Misses      12488    12489       +1     
Impacted Files Coverage Δ
boa_engine/src/context/intrinsics.rs 57.74% <33.33%> (+0.19%) ⬆️
boa_engine/src/builtins/array/mod.rs 75.68% <100.00%> (ø)
boa_engine/src/builtins/function/arguments.rs 81.63% <100.00%> (+0.78%) ⬆️
boa_engine/src/context/mod.rs 31.14% <0.00%> (+0.30%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :) thanks!

@HalidOdat
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Aug 17, 2022
This Pull Request changes the following:

- Create the `%Array.prototype.values%` function object once and use it in both the `Array` prototype and as the `@@iterator` value of `arguments` objects.

This fixes a test where `arguments[Symbol.iterator]` and `[][Symbol.iterator]` would not be equal.
@bors
Copy link

bors bot commented Aug 17, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix arguments object iterator function [Merged by Bors] - Fix arguments object iterator function Aug 17, 2022
@bors bors bot closed this Aug 17, 2022
@bors bors bot deleted the fix-arguments-object-iter branch August 17, 2022 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants