-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Fix arguments
object iterator function
#2231
Conversation
Test262 conformance changesVM implementation
Fixed tests (2):
|
Codecov Report
@@ Coverage Diff @@
## main #2231 +/- ##
==========================================
+ Coverage 41.99% 42.00% +0.01%
==========================================
Files 231 231
Lines 21530 21536 +6
==========================================
+ Hits 9042 9047 +5
- Misses 12488 12489 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me :) thanks!
bors r+ |
This Pull Request changes the following: - Create the `%Array.prototype.values%` function object once and use it in both the `Array` prototype and as the `@@iterator` value of `arguments` objects. This fixes a test where `arguments[Symbol.iterator]` and `[][Symbol.iterator]` would not be equal.
Pull request successfully merged into main. Build succeeded: |
arguments
object iterator functionarguments
object iterator function
This Pull Request changes the following:
%Array.prototype.values%
function object once and use it in both theArray
prototype and as the@@iterator
value ofarguments
objects.This fixes a test where
arguments[Symbol.iterator]
and[][Symbol.iterator]
would not be equal.