-
-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Parse class private async generator methods #2220
Conversation
Test262 conformance changesVM implementation
Fixed tests (4):
|
Codecov Report
@@ Coverage Diff @@
## main #2220 +/- ##
==========================================
- Coverage 41.91% 41.91% -0.01%
==========================================
Files 231 231
Lines 21497 21513 +16
==========================================
+ Hits 9011 9017 +6
- Misses 12486 12496 +10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for the fix :) I will try to review the other PRs as soon as possible in the next days :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks perfect to me! :)
bors r+ |
Currently async generator class methods are not being parsed correctly. In comparison to the current main branch this only fixes a few tests, but after #2200 is merged, it should be aroud 1000 additional passing tests.
Pull request successfully merged into main. Build succeeded: |
Currently async generator class methods are not being parsed correctly. In comparison to the current main branch this only fixes a few tests, but after #2200 is merged, it should be aroud 1000 additional passing tests.