Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Add field accessors to destructing assignment #2213

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Add field accessors to destructing assignment #2213

wants to merge 1 commit into from

Conversation

raskad
Copy link
Member

@raskad raskad commented Aug 2, 2022

This Pull Request changes the following:

  • Implement parsing/cover-conversion for field accessor member expressions in DestructuringAssignmentTarget.
  • Modify the CopyDataProperties opcode to account for excluded keys that are only known at runtime.

@raskad raskad added enhancement New feature or request parser Issues surrounding the parser execution Issues or PRs related to code execution labels Aug 2, 2022
@raskad raskad added this to the v0.16.0 milestone Aug 2, 2022
@github-actions
Copy link

github-actions bot commented Aug 2, 2022 •
edited
Loading

Test262 conformance changes

VM implementation

Test result main count PR count difference
Total 91,573 91,573 0
Passed 64,752 64,816 +64
Ignored 14,606 14,606 0
Failed 12,215 12,151 -64
Panics 0 0 0
Conformance 70.71% 70.78% +0.07%
Fixed tests (64): 
test/language/statements/for-of/dstr/obj-rest-non-string-computed-property-1dot.js [strict mode] (previously Failed)
test/language/statements/for-of/dstr/obj-rest-non-string-computed-property-1dot.js (previously Failed)
test/language/statements/for-of/dstr/obj-prop-elem-target-obj-literal-prop-ref.js [strict mode] (previously Failed)
test/language/statements/for-of/dstr/obj-prop-elem-target-obj-literal-prop-ref.js (previously Failed)
test/language/statements/for-of/dstr/obj-prop-elem-target-obj-literal-prop-ref-init.js [strict mode] (previously Failed)
test/language/statements/for-of/dstr/obj-prop-elem-target-obj-literal-prop-ref-init.js (previously Failed)
test/language/statements/for-of/dstr/obj-rest-computed-property.js [strict mode] (previously Failed)
test/language/statements/for-of/dstr/obj-rest-computed-property.js (previously Failed)
test/language/statements/for-of/dstr/obj-rest-non-string-computed-property-string-1.js [strict mode] (previously Failed)
test/language/statements/for-of/dstr/obj-rest-non-string-computed-property-string-1.js (previously Failed)
test/language/statements/for-of/dstr/obj-prop-put-prop-ref.js [strict mode] (previously Failed)
test/language/statements/for-of/dstr/obj-prop-put-prop-ref.js (previously Failed)
test/language/statements/for-of/dstr/obj-prop-put-prop-ref-no-get.js [strict mode] (previously Failed)
test/language/statements/for-of/dstr/obj-prop-put-prop-ref-no-get.js (previously Failed)
test/language/statements/for-of/dstr/obj-prop-put-prop-ref-user-err.js [strict mode] (previously Failed)
test/language/statements/for-of/dstr/obj-prop-put-prop-ref-user-err.js (previously Failed)
test/language/statements/for-of/dstr/obj-rest-non-string-computed-property-1e0.js [strict mode] (previously Failed)
test/language/statements/for-of/dstr/obj-rest-non-string-computed-property-1e0.js (previously Failed)
test/language/statements/for-of/dstr/obj-rest-non-string-computed-property-array-1e0.js [strict mode] (previously Failed)
test/language/statements/for-of/dstr/obj-rest-non-string-computed-property-array-1e0.js (previously Failed)
test/language/statements/for-of/dstr/obj-rest-non-string-computed-property-1.js [strict mode] (previously Failed)
test/language/statements/for-of/dstr/obj-rest-non-string-computed-property-1.js (previously Failed)
test/language/statements/for-of/dstr/obj-prop-elem-target-yield-ident-valid.js (previously Failed)
test/language/statements/for-of/dstr/obj-prop-elem-target-obj-literal-prop-ref-init-active.js [strict mode] (previously Failed)
test/language/statements/for-of/dstr/obj-prop-elem-target-obj-literal-prop-ref-init-active.js (previously Failed)
test/language/statements/for-of/dstr/obj-rest-computed-property-no-strict.js (previously Failed)
test/language/statements/for-of/dstr/obj-rest-non-string-computed-property-1dot0.js [strict mode] (previously Failed)
test/language/statements/for-of/dstr/obj-rest-non-string-computed-property-1dot0.js (previously Failed)
test/language/statements/for-of/dstr/obj-rest-non-string-computed-property-array-1.js [strict mode] (previously Failed)
test/language/statements/for-of/dstr/obj-rest-non-string-computed-property-array-1.js (previously Failed)
test/language/expressions/assignment/dstr/obj-rest-non-string-computed-property-1dot.js [strict mode] (previously Failed)
test/language/expressions/assignment/dstr/obj-rest-non-string-computed-property-1dot.js (previously Failed)
test/language/expressions/assignment/dstr/obj-prop-elem-target-obj-literal-prop-ref.js [strict mode] (previously Failed)
test/language/expressions/assignment/dstr/obj-prop-elem-target-obj-literal-prop-ref.js (previously Failed)
test/language/expressions/assignment/dstr/obj-prop-elem-target-obj-literal-prop-ref-init.js [strict mode] (previously Failed)
test/language/expressions/assignment/dstr/obj-prop-elem-target-obj-literal-prop-ref-init.js (previously Failed)
test/language/expressions/assignment/dstr/obj-rest-computed-property.js [strict mode] (previously Failed)
test/language/expressions/assignment/dstr/obj-rest-computed-property.js (previously Failed)
test/language/expressions/assignment/dstr/obj-rest-non-string-computed-property-string-1.js [strict mode] (previously Failed)
test/language/expressions/assignment/dstr/obj-rest-non-string-computed-property-string-1.js (previously Failed)
test/language/expressions/assignment/dstr/obj-prop-put-prop-ref.js [strict mode] (previously Failed)
test/language/expressions/assignment/dstr/obj-prop-put-prop-ref.js (previously Failed)
test/language/expressions/assignment/dstr/obj-prop-put-prop-ref-no-get.js [strict mode] (previously Failed)
test/language/expressions/assignment/dstr/obj-prop-put-prop-ref-no-get.js (previously Failed)
test/language/expressions/assignment/dstr/obj-prop-put-prop-ref-user-err.js [strict mode] (previously Failed)
test/language/expressions/assignment/dstr/obj-prop-put-prop-ref-user-err.js (previously Failed)
test/language/expressions/assignment/dstr/obj-rest-non-string-computed-property-1e0.js [strict mode] (previously Failed)
test/language/expressions/assignment/dstr/obj-rest-non-string-computed-property-1e0.js (previously Failed)
test/language/expressions/assignment/dstr/obj-rest-non-string-computed-property-array-1e0.js [strict mode] (previously Failed)
test/language/expressions/assignment/dstr/obj-rest-non-string-computed-property-array-1e0.js (previously Failed)
test/language/expressions/assignment/dstr/obj-rest-non-string-computed-property-1.js [strict mode] (previously Failed)
test/language/expressions/assignment/dstr/obj-rest-non-string-computed-property-1.js (previously Failed)
test/language/expressions/assignment/dstr/obj-prop-elem-target-yield-ident-valid.js (previously Failed)
test/language/expressions/assignment/dstr/obj-prop-elem-target-obj-literal-prop-ref-init-active.js [strict mode] (previously Failed)
test/language/expressions/assignment/dstr/obj-prop-elem-target-obj-literal-prop-ref-init-active.js (previously Failed)
test/language/expressions/assignment/dstr/obj-rest-computed-property-no-strict.js (previously Failed)
test/language/expressions/assignment/dstr/obj-prop-elem-target-yield-expr.js [strict mode] (previously Failed)
test/language/expressions/assignment/dstr/obj-prop-elem-target-yield-expr.js (previously Failed)
test/language/expressions/assignment/dstr/obj-rest-non-string-computed-property-1dot0.js [strict mode] (previously Failed)
test/language/expressions/assignment/dstr/obj-rest-non-string-computed-property-1dot0.js (previously Failed)
test/language/expressions/assignment/dstr/obj-rest-non-string-computed-property-array-1.js [strict mode] (previously Failed)
test/language/expressions/assignment/dstr/obj-rest-non-string-computed-property-array-1.js (previously Failed)
test/language/expressions/object/dstr/object-rest-proxy-gopd-not-called-on-excluded-keys.js [strict mode] (previously Failed)
test/language/expressions/object/dstr/object-rest-proxy-gopd-not-called-on-excluded-keys.js (previously Failed)

@codecov
Copy link

codecov bot commented Aug 2, 2022 •
edited
Loading

Codecov Report

Merging #2213 (7614d32) into main (5909e9a) will decrease coverage by 0.18%.
The diff coverage is 3.54%.

@@            Coverage Diff             @@
##             main    #2213      +/-   ##
==========================================
- Coverage   41.54%   41.35%   -0.19%     
==========================================
  Files         234      234              
  Lines       21891    22000     +109     
==========================================
+ Hits         9094     9099       +5     
- Misses      12797    12901     +104
Impacted Files Coverage Δ
boa_engine/src/syntax/ast/node/object/mod.rs 50.90% <0.00%> (ø)
..._engine/src/syntax/ast/node/operator/assign/mod.rs 14.64% <0.00%> (-1.00%) ⬇️
boa_engine/src/vm/code_block.rs 32.80% <ø> (ø)
boa_engine/src/vm/opcode.rs 50.00% <ø> (ø)
boa_engine/src/bytecompiler/mod.rs 28.70% <2.89%> (-0.74%) ⬇️
boa_engine/src/syntax/ast/node/declaration/mod.rs 36.29% <3.22%> (-3.31%) ⬇️
boa_engine/src/vm/mod.rs 46.44% <15.38%> (-0.27%) ⬇️
...a_engine/src/syntax/parser/statement/switch/mod.rs 38.37% <0.00%> (-1.17%) ⬇️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@raskad raskad force-pushed the dstr-assignment-field-access branch from c5dbbe4 to 6da1ab6 Compare August 12, 2022 19:12
Razican
Razican approved these changes Aug 13, 2022
View reviewed changes
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@raskad raskad force-pushed the dstr-assignment-field-access branch from 6da1ab6 to 7614d32 Compare August 13, 2022 23:38
@raskad
Copy link
Member Author

raskad commented Aug 14, 2022

bors r+

bors bot pushed a commit that referenced this pull request Aug 14, 2022
@raskad
Add field accessors to destructing assignment (#2213)
2dcdf51 
This Pull Request changes the following:

- Implement parsing/cover-conversion for field accessor member expressions in [DestructuringAssignmentTarget](https://tc39.es/ecma262/#prod-DestructuringAssignmentTarget).
- Modify the `CopyDataProperties` opcode to account for excluded keys that are only known at runtime.
@bors
Copy link

bors bot commented Aug 14, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Add field accessors to destructing assignment [Merged by Bors] - Add field accessors to destructing assignment Aug 14, 2022
@bors bors bot closed this Aug 14, 2022
@bors bors bot deleted the dstr-assignment-field-access branch August 14, 2022 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HalidOdat HalidOdat HalidOdat approved these changes

@Razican Razican Razican approved these changes

@jasonwilliams jasonwilliams Awaiting requested review from jasonwilliams

@RageKnify RageKnify Awaiting requested review from RageKnify

@jedel1043 jedel1043 Awaiting requested review from jedel1043

Assignees
No one assigned
Labels
enhancement New feature or request execution Issues or PRs related to code execution parser Issues surrounding the parser
Projects
None yet
Milestone
v0.16.0
Development

Successfully merging this pull request may close these issues.
3 participants
@raskad @Razican @HalidOdat