[Merged by Bors] - Implement arrow function parsing based on CoverParenthesizedExpressionAndArrowParameterList
#2171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nAndArrowParameterList
raskad
added
enhancement
raskad
requested review from
Razican,
jasonwilliams,
HalidOdat,
RageKnify and
jedel1043
Test262 conformance changesVM implementation
Fixed tests (694): |
Codecov Report
@@ Coverage Diff @@
## main #2171 +/- ##
==========================================
- Coverage 42.04% 41.89% -0.16%
==========================================
Files 231 231
Lines 21271 21498 +227
==========================================
+ Hits 8943 9006 +63
- Misses 12328 12492 +164
Continue to review full report at Codecov.
|
Razican
reviewed
Jul 9, 2022
Razican
approved these changes
Jul 9, 2022
boa_engine/src/syntax/parser/expression/primary/object_initializer/mod.rs
Outdated
Show resolved
Hide resolved
Razican
reviewed
Jul 10, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 11, 2022
…onAndArrowParameterList` (#2171) Previously we parsed arrow functions without the relevant cover grammar `CoverParenthesizedExpressionAndArrowParameterList`. This leads to either arrow functions or parenthesized expressions not being parsed correctly. Implementing this is a bit tricky, as the cover grammar is being parsed in `PrimaryExpression` while arrow functions are parsed in `AssignmentExpression`. This means that we have to return the covered parameter list that was parsed via `CoverParenthesizedExpressionAndArrowParameterList` in `PrimaryExpression` to `AssignmentExpression`. Fortunately this works pretty good and now the full arrow function test suite, with the exception of a few tests that require other features, passes. This Pull Request changes the following: - Implement `CoverParenthesizedExpressionAndArrowParameterList` parsing. - Implement `CoverInitializedName` parsing in object literals. - Fix a bug where an environment would be wrongly removed from the environment stack when an expression in default function parameters throws. - Add more valid cases where on object literal can be converted to an object declaration pattern. - Implement `Expression` parsing manually to avoid some cases where the parser would prematurely throw an error. - Implement parsing of arrow functions via `CoverParenthesizedExpressionAndArrowParameterList`. - Remove unneeded `AllowIn` flag on array and object declaration pattern parsers. - Fix an of-by-one bug in the trace output.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
CoverParenthesizedExpressionAndArrowParameterListCoverParenthesizedExpressionAndArrowParameterList
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we parsed arrow functions without the relevant cover grammar
CoverParenthesizedExpressionAndArrowParameterList. This leads to either arrow functions or parenthesized expressions not being parsed correctly. Implementing this is a bit tricky, as the cover grammar is being parsed inPrimaryExpressionwhile arrow functions are parsed inAssignmentExpression. This means that we have to return the covered parameter list that was parsed viaCoverParenthesizedExpressionAndArrowParameterListinPrimaryExpressiontoAssignmentExpression. Fortunately this works pretty good and now the full arrow function test suite, with the exception of a few tests that require other features, passes.This Pull Request changes the following:
CoverParenthesizedExpressionAndArrowParameterListparsing.CoverInitializedNameparsing in object literals.Expressionparsing manually to avoid some cases where the parser would prematurely throw an error.CoverParenthesizedExpressionAndArrowParameterList.AllowInflag on array and object declaration pattern parsers.