[Merged by Bors] - Store call frames in Vec instead of singly-linked list
#2164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HalidOdat
added
Internal
HalidOdat
requested review from
Razican,
jasonwilliams,
RageKnify,
raskad and
jedel1043
Test262 conformance changesVM implementation
Fixed tests (2): |
Codecov Report
@@ Coverage Diff @@
## main #2164 +/- ##
==========================================
+ Coverage 42.43% 42.69% +0.26%
==========================================
Files 226 225 -1
Lines 20996 20790 -206
==========================================
- Hits 8909 8877 -32
+ Misses 12087 11913 -174
Continue to review full report at Codecov.
|
Benchmark for 23444adClick to view benchmark
|
raskad
approved these changes
Jul 5, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 5, 2022
This storage method should be more cache friendly since we store in contiguous memory, besides that it should make #2157 a bit easier. Will work on that next after this gets merged :) It changes the following: - Remove the unneeded `prev` field in `CallFrame` - Preallocate some space for future calls (16 slots)
|
Build failed: |
- Remove the unneeded `prev` field in `CallFrame` - Preallocate some space for future calls (16 slots) - Rename Vm::frame => Vm::frames
Benchmark for ba0aa7eClick to view benchmark
|
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 5, 2022
This storage method should be more cache friendly since we store in contiguous memory, besides that it should make #2157 a bit easier. Will work on that next after this gets merged :) It changes the following: - Remove the unneeded `prev` field in `CallFrame` - Preallocate some space for future calls (16 slots)
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Vec instead of singly-linked listVec instead of singly-linked list
|
@HalidOdat I think you accidentally changed to an outdated version of the 262 submodule in the last push here right? |
yes... I mistakingly committed it 😅 , created a PR #2166 that updates the test262 to the latest |
lameferret
pushed a commit
to lameferret/boa
that referenced
this pull request
Jul 6, 2022
This storage method should be more cache friendly since we store in contiguous memory, besides that it should make boa-dev#2157 a bit easier. Will work on that next after this gets merged :) It changes the following: - Remove the unneeded `prev` field in `CallFrame` - Preallocate some space for future calls (16 slots)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This storage method should be more cache friendly since we store in contiguous memory, besides that it should make #2157 a bit easier. Will work on that next after this gets merged :)
It changes the following:
prevfield inCallFrame