Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fix clippy 1.62.0 lints #2154

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Fix clippy 1.62.0 lints #2154

wants to merge 2 commits into from

Conversation

raskad
Copy link
Member

@raskad raskad commented Jun 30, 2022

This Pull Request changes the following:

  • Fix clippy 1.62.0 lints

@raskad raskad added rust Pull requests that update Rust code Internal Category for changelog labels Jun 30, 2022
@raskad raskad added this to the v0.16.0 milestone Jun 30, 2022
@github-actions
Copy link

Test262 conformance changes

VM implementation

Test result main count PR count difference
Total 90,663 90,663 0
Passed 58,166 58,166 0
Ignored 13,832 13,832 0
Failed 18,665 18,665 0
Panics 0 0 0
Conformance 64.16% 64.16% 0.00%

@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #2154 (42606be) into main (13df9a1) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2154      +/-   ##
==========================================
+ Coverage   42.68%   42.73%   +0.04%     
==========================================
  Files         222      225       +3     
  Lines       20763    20780      +17     
==========================================
+ Hits         8863     8880      +17     
  Misses      11900    11900              
Impacted Files Coverage Δ
boa_engine/src/lib.rs 86.66% <ø> (ø)
boa_engine/src/builtins/string/mod.rs 63.94% <100.00%> (+0.28%) ⬆️
boa_engine/src/syntax/lexer/mod.rs 50.00% <100.00%> (+1.69%) ⬆️
boa_engine/src/syntax/lexer/number.rs 49.70% <100.00%> (ø)
boa_engine/src/syntax/ast/node/spread/mod.rs 57.14% <0.00%> (-14.29%) ⬇️
boa_engine/src/syntax/ast/node/identifier/mod.rs 18.18% <0.00%> (-9.10%) ⬇️
boa_engine/src/syntax/ast/node/iteration/mod.rs 66.66% <0.00%> (-4.77%) ⬇️
...a_engine/src/syntax/ast/node/statement_list/mod.rs 78.12% <0.00%> (-3.13%) ⬇️
boa_engine/src/syntax/lexer/template.rs 36.95% <0.00%> (-2.63%) ⬇️
...ntax/parser/expression/left_hand_side/arguments.rs 35.00% <0.00%> (-2.50%) ⬇️
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13df9a1...42606be. Read the comment docs.

Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :) just a couple of potential enhancements on readability.

boa_engine/src/builtins/string/mod.rs Outdated Show resolved Hide resolved
boa_engine/src/builtins/string/mod.rs Outdated Show resolved Hide resolved
@raskad
Copy link
Member Author

raskad commented Jun 30, 2022

bors r+

@bors
Copy link

bors bot commented Jun 30, 2022

🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

@raskad
Copy link
Member Author

raskad commented Jun 30, 2022

bors r+

bors bot pushed a commit that referenced this pull request Jun 30, 2022
This Pull Request changes the following:

- Fix clippy 1.62.0 lints
@bors
Copy link

bors bot commented Jun 30, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix clippy 1.62.0 lints [Merged by Bors] - Fix clippy 1.62.0 lints Jun 30, 2022
@bors bors bot closed this Jun 30, 2022
@bors bors bot deleted the fix-lints branch June 30, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Category for changelog rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants