[Merged by Bors] - Prevent PR benchmarks to run on label changes #2119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raskad
requested review from
Razican,
jasonwilliams,
HalidOdat,
RageKnify and
jedel1043
Test262 conformance changesVM implementation
|
Codecov Report
@@ Coverage Diff @@
## main #2119 +/- ##
=======================================
Coverage 43.57% 43.57%
=======================================
Files 217 217
Lines 19695 19695
=======================================
Hits 8583 8583
Misses 11112 11112 Continue to review full report at Codecov.
|
jedel1043
approved these changes
Jun 13, 2022
Razican
approved these changes
Jun 13, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jun 13, 2022
This changes the trigger type for PR benchmarks back to the default (`opened`, `synchronize`, `reopened`). As part of #2114 I added the `labeled` trigger type. This causes the benchmarks to run when the `run-benchmark` label is present and another label is added. For example in #2116 I added the `run-benchmark` label while creating the PR. The benchmarks then where triggered six times; one for the PR creation (`opened`) and five times for each label that I initially added to the PR. The only drawback is that the benchmarks are not triggered, when we just add the label, but unfortunately I don't have a clever idea on how to achieve that right now. We will have to add the label and then trigger the run via a `synchronize` (push).
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the trigger type for PR benchmarks back to the default (
opened,synchronize,reopened). As part of #2114 I added thelabeledtrigger type. This causes the benchmarks to run when therun-benchmarklabel is present and another label is added.For example in #2116 I added the
run-benchmarklabel while creating the PR. The benchmarks then where triggered six times; one for the PR creation (opened) and five times for each label that I initially added to the PR.The only drawback is that the benchmarks are not triggered, when we just add the label, but unfortunately I don't have a clever idea on how to achieve that right now. We will have to add the label and then trigger the run via a
synchronize(push).