Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Improve JsString performance #2042

Closed
wants to merge 14 commits into from
Closed

[Merged by Bors] - Improve JsString performance #2042

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
e8ef21d
perf(string): No more heap allocation of static strings
YXL76 Apr 23, 2022
3598379
Add more elements to `CONSTANTS_ARRAY`
YXL76 Apr 23, 2022
574f722
Remove `StaticStr`
YXL76 Apr 23, 2022
effcaa4
fix: Clippy lints
YXL76 Apr 23, 2022
119e547
Make meaning of `inner` more clear
YXL76 Apr 24, 2022
1b2236e
Fix clippy lints
YXL76 Apr 24, 2022
c0bb509
revert effcaa40
YXL76 Apr 24, 2022
34494a1
Fix clippy and add some tests
YXL76 Apr 24, 2022
31feb14
Use `get_unchecked`
YXL76 Apr 25, 2022
46f7f8b
Fix `miri` error
YXL76 Apr 26, 2022
29fadb2
Clearer documentation
YXL76 Apr 27, 2022
9349a08
Change `CONSTANTS`
YXL76 Apr 27, 2022
456cd19
Better type
YXL76 Apr 27, 2022
698a517
Fix memory leak
YXL76 Apr 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions boa_engine/src/bigint.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ impl JsBigInt {
let inner = if n > 0 {
x.inner.as_ref().clone().shr(n as usize)
} else {
x.inner.as_ref().clone().shl(n.abs() as usize)
x.inner.as_ref().clone().shl(n.unsigned_abs())
raskad marked this conversation as resolved.
Show resolved Hide resolved
};

Ok(Self::new(inner))
Expand All @@ -195,7 +195,7 @@ impl JsBigInt {
let inner = if n > 0 {
x.inner.as_ref().clone().shl(n as usize)
} else {
x.inner.as_ref().clone().shr(n.abs() as usize)
x.inner.as_ref().clone().shr(n.unsigned_abs())
raskad marked this conversation as resolved.
Show resolved Hide resolved
};

Ok(Self::new(inner))
Expand Down
Loading