[Merged by Bors] - Partial implementation for Intl.DateTimeFormat #2025

NorbertGarfield · 2022-04-11T17:15:34Z

This Pull Request provides initial implementation for DateTimeFormat constructor. It relates to #1562.

It changes the following:

Adds Intl.DateTimeFormat property
Partially implements DateTimeFormat constructor (InitializeDateTimeFormat step is postponed).
Introduces ObjectData::DateTimeFormat

codecov · 2022-04-11T20:48:02Z

Codecov Report

Merging #2025 (eddb5d4) into main (c605fad) will decrease coverage by 0.03%.
The diff coverage is 17.24%.

@@            Coverage Diff             @@
##             main    #2025      +/-   ##
==========================================
- Coverage   43.94%   43.90%   -0.04%     
==========================================
  Files         211      212       +1     
  Lines       18704    18734      +30     
==========================================
+ Hits         8220     8226       +6     
- Misses      10484    10508      +24

Impacted Files	Coverage Δ
boa_engine/src/context/intrinsics.rs	`58.59% <0.00%> (-0.61%)`	⬇️
boa_engine/src/object/mod.rs	`21.08% <0.00%> (-0.03%)`	⬇️
boa_engine/src/builtins/intl/date_time_format.rs	`12.50% <12.50%> (ø)`
boa_engine/src/builtins/intl/mod.rs	`28.00% <100.00%> (+6.26%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c605fad...eddb5d4. Read the comment docs.

boa_engine/src/builtins/intl/mod.rs

boa_engine/src/builtins/intl/date_time_format.rs

boa_engine/src/builtins/intl/mod.rs

HalidOdat · 2022-04-13T20:51:55Z

VM implementation

Test result	main count	PR count	difference
Total	88,720	88,720	0
Passed	53,146	53,190	+44
Ignored	21,853	21,853	0
Failed	13,721	13,677	-44
Panics	0	0	0
Conformance	59.90%	59.95%	+0.05%

Fixed tests (50):

test/intl402/DateTimeFormat/length.js [strict mode] (previously Failed)
test/intl402/DateTimeFormat/length.js (previously Failed)
test/intl402/DateTimeFormat/builtin.js [strict mode] (previously Failed)
test/intl402/DateTimeFormat/builtin.js (previously Failed)
test/intl402/DateTimeFormat/intl-legacy-constructed-symbol.js [strict mode] (previously Failed)
test/intl402/DateTimeFormat/intl-legacy-constructed-symbol.js (previously Failed)
test/intl402/DateTimeFormat/instance-proto-and-extensible.js [strict mode] (previously Failed)
test/intl402/DateTimeFormat/instance-proto-and-extensible.js (previously Failed)
test/intl402/DateTimeFormat/name.js [strict mode] (previously Failed)
test/intl402/DateTimeFormat/name.js (previously Failed)
test/intl402/DateTimeFormat/intl-legacy-constructed-symbol-on-unwrap.js [strict mode] (previously Failed)
test/intl402/DateTimeFormat/intl-legacy-constructed-symbol-on-unwrap.js (previously Failed)
test/intl402/DateTimeFormat/prop-desc.js [strict mode] (previously Failed)
test/intl402/DateTimeFormat/prop-desc.js (previously Failed)
test/intl402/DateTimeFormat/constructor-no-instanceof.js [strict mode] (previously Failed)
test/intl402/DateTimeFormat/constructor-no-instanceof.js (previously Failed)
test/intl402/DateTimeFormat/legacy-regexp-statics-not-modified.js [strict mode] (previously Failed)
test/intl402/DateTimeFormat/legacy-regexp-statics-not-modified.js (previously Failed)
test/intl402/DateTimeFormat/prototype/builtin.js [strict mode] (previously Failed)
test/intl402/DateTimeFormat/prototype/builtin.js (previously Failed)
test/intl402/DateTimeFormat/prototype/prop-desc.js [strict mode] (previously Failed)
test/intl402/DateTimeFormat/prototype/prop-desc.js (previously Failed)
test/intl402/DateTimeFormat/prototype/toStringTag/toString-removed-tag.js [strict mode] (previously Failed)
test/intl402/DateTimeFormat/prototype/toStringTag/toString-removed-tag.js (previously Failed)
test/intl402/DateTimeFormat/prototype/toStringTag/toString-changed-tag.js [strict mode] (previously Failed)
test/intl402/DateTimeFormat/prototype/toStringTag/toString-changed-tag.js (previously Failed)
test/intl402/DateTimeFormat/prototype/formatRange/this-bad-object.js [strict mode] (previously Failed)
test/intl402/DateTimeFormat/prototype/formatRange/this-bad-object.js (previously Failed)
test/intl402/DateTimeFormat/prototype/formatRange/date-undefined-throws.js [strict mode] (previously Failed)
test/intl402/DateTimeFormat/prototype/formatRange/date-undefined-throws.js (previously Failed)
test/intl402/DateTimeFormat/prototype/formatRange/this-is-not-object-throws.js [strict mode] (previously Failed)
test/intl402/DateTimeFormat/prototype/formatRange/this-is-not-object-throws.js (previously Failed)
test/intl402/DateTimeFormat/prototype/format/no-instanceof.js [strict mode] (previously Failed)
test/intl402/DateTimeFormat/prototype/format/no-instanceof.js (previously Failed)
test/intl402/DateTimeFormat/prototype/constructor/value.js [strict mode] (previously Failed)
test/intl402/DateTimeFormat/prototype/constructor/value.js (previously Failed)
test/intl402/DateTimeFormat/prototype/constructor/prop-desc.js [strict mode] (previously Failed)
test/intl402/DateTimeFormat/prototype/constructor/prop-desc.js (previously Failed)
test/intl402/DateTimeFormat/prototype/formatToParts/this-has-not-internal-throws.js [strict mode] (previously Failed)
test/intl402/DateTimeFormat/prototype/formatToParts/this-has-not-internal-throws.js (previously Failed)
test/intl402/DateTimeFormat/prototype/formatToParts/this-is-not-object-throws.js [strict mode] (previously Failed)
test/intl402/DateTimeFormat/prototype/formatToParts/this-is-not-object-throws.js (previously Failed)
test/intl402/DateTimeFormat/prototype/formatRangeToParts/this-bad-object.js [strict mode] (previously Failed)
test/intl402/DateTimeFormat/prototype/formatRangeToParts/this-bad-object.js (previously Failed)
test/intl402/DateTimeFormat/prototype/formatRangeToParts/date-undefined-throws.js [strict mode] (previously Failed)
test/intl402/DateTimeFormat/prototype/formatRangeToParts/date-undefined-throws.js (previously Failed)
test/intl402/DateTimeFormat/prototype/formatRangeToParts/this-is-not-object-throws.js [strict mode] (previously Failed)
test/intl402/DateTimeFormat/prototype/formatRangeToParts/this-is-not-object-throws.js (previously Failed)
test/intl402/DateTimeFormat/supportedLocalesOf/taint-Object-prototype.js [strict mode] (previously Failed)
test/intl402/DateTimeFormat/supportedLocalesOf/taint-Object-prototype.js (previously Failed)

Broken tests (6):

test/intl402/DateTimeFormat/constructor-options-style-conflict.js [strict mode] (previously Passed)
test/intl402/DateTimeFormat/constructor-options-style-conflict.js (previously Passed)
test/intl402/DateTimeFormat/this-value-ignored.js [strict mode] (previously Passed)
test/intl402/DateTimeFormat/this-value-ignored.js (previously Passed)
test/intl402/NumberFormat/this-value-ignored.js [strict mode] (previously Passed)
test/intl402/NumberFormat/this-value-ignored.js (previously Passed)

NorbertGarfield · 2022-04-13T21:39:38Z

@HalidOdat it seems to me that 6 failing tests were previously passing because DateTimeFormat was unavailable. E.g. test/intl402/DateTimeFormat/constructor-options-style-conflict.js:

  assert.throws(TypeError, function() {
    new Intl.DateTimeFormat("en", { [option]: value, timeStyle: "short" });
  }, `new Intl.DateTimeFormat("en", { ${option}: "${value}",  timeStyle: "short" }) throws TypeError`);

In order to fix that I need to either implement InitializeDateTimeFormat properly (which seemed a little bit ambitious to me, so I postponed it) or alter DateTimeFormat constructor to always fail. What would you recommend?

Thanks.

HalidOdat · 2022-04-16T19:28:35Z

Sorry for late response

In order to fix that I need to either implement InitializeDateTimeFormat properly (which seemed a little bit ambitious to me, so I postponed it) or alter DateTimeFormat constructor to always fail. What would you recommend?

You can leave it as is, just put a TODO on the steps in the constructor that are not implemented.

NorbertGarfield · 2022-04-18T14:32:49Z

Added TODO for missing steps: https://github.com/boa-dev/boa/pull/2025/files#diff-d3b068b8d1eb849b10fde7458b9cfc96c68353420893ef2ca613b258884c1756R106

Razican

Looks good to me :) thank you for the implementation!!

Razican · 2022-04-19T14:57:04Z

bors r+

This Pull Request provides initial implementation for DateTimeFormat constructor. It relates to #1562. It changes the following: - Adds `Intl.DateTimeFormat` property - Partially implements `DateTimeFormat` constructor (`InitializeDateTimeFormat` step is postponed). - Introduces `ObjectData::DateTimeFormat`

bors · 2022-04-19T15:05:39Z

Pull request successfully merged into main.

Build succeeded:

This Pull Request provides initial implementation for DateTimeFormat constructor. It relates to #1562. It changes the following: - Adds `Intl.DateTimeFormat` property - Partially implements `DateTimeFormat` constructor (`InitializeDateTimeFormat` step is postponed). - Introduces `ObjectData::DateTimeFormat`

NorbertGarfield force-pushed the garfield/date-time-format branch from afad01b to a68edde Compare April 11, 2022 20:39

HalidOdat reviewed Apr 13, 2022

View reviewed changes

boa_engine/src/builtins/intl/mod.rs Outdated Show resolved Hide resolved

boa_engine/src/builtins/intl/mod.rs Outdated Show resolved Hide resolved

boa_engine/src/builtins/intl/mod.rs Outdated Show resolved Hide resolved

HalidOdat added the enhancement New feature or request label Apr 13, 2022

NorbertGarfield requested a review from HalidOdat April 13, 2022 18:37

HalidOdat reviewed Apr 13, 2022

View reviewed changes

boa_engine/src/builtins/intl/date_time_format.rs Outdated Show resolved Hide resolved

boa_engine/src/builtins/intl/date_time_format.rs Show resolved Hide resolved

boa_engine/src/builtins/intl/mod.rs Outdated Show resolved Hide resolved

NorbertGarfield requested a review from HalidOdat April 13, 2022 21:34

NorbertGarfield added 4 commits April 18, 2022 14:26

Initial implementation for Intl.DateTimeFormat

902cf72

Use ConstructorBuilder

68e931f

Drop BuiltIn trait for DateTimeFormat

37ee8a0

Mark missing DateTimeFormat steps with TODO

eddb5d4

NorbertGarfield force-pushed the garfield/date-time-format branch from 181dd42 to eddb5d4 Compare April 18, 2022 14:30

Razican approved these changes Apr 18, 2022

View reviewed changes

Razican requested review from jedel1043, raskad, jasonwilliams, RageKnify and HalidOdat and removed request for HalidOdat April 18, 2022 17:10

HalidOdat approved these changes Apr 19, 2022

View reviewed changes

HalidOdat changed the title ~~Initial implementation for Intl.DateTimeFormat~~ Partial implementation for Intl.DateTimeFormat Apr 19, 2022

bors bot changed the title ~~Partial implementation for Intl.DateTimeFormat~~ [Merged by Bors] - Partial implementation for Intl.DateTimeFormat Apr 19, 2022

bors bot closed this Apr 19, 2022

Razican added this to the v0.15.0 milestone Jun 1, 2022

Razican added the builtins PRs and Issues related to builtins/intrinsics label Jun 1, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Merged by Bors] - Partial implementation for Intl.DateTimeFormat #2025

[Merged by Bors] - Partial implementation for Intl.DateTimeFormat #2025

NorbertGarfield commented Apr 11, 2022 •

edited

Loading

codecov bot commented Apr 11, 2022 •

edited

Loading

HalidOdat commented Apr 13, 2022

NorbertGarfield commented Apr 13, 2022 •

edited

Loading

HalidOdat commented Apr 16, 2022

NorbertGarfield commented Apr 18, 2022

Razican left a comment

Razican commented Apr 19, 2022

bors bot commented Apr 19, 2022

[Merged by Bors] - Partial implementation for Intl.DateTimeFormat #2025

[Merged by Bors] - Partial implementation for Intl.DateTimeFormat #2025

Conversation

NorbertGarfield commented Apr 11, 2022 • edited Loading

codecov bot commented Apr 11, 2022 • edited Loading

Codecov Report

HalidOdat commented Apr 13, 2022

VM implementation

NorbertGarfield commented Apr 13, 2022 • edited Loading

HalidOdat commented Apr 16, 2022

NorbertGarfield commented Apr 18, 2022

Razican left a comment

Choose a reason for hiding this comment

Razican commented Apr 19, 2022

bors bot commented Apr 19, 2022

NorbertGarfield commented Apr 11, 2022 •

edited

Loading

codecov bot commented Apr 11, 2022 •

edited

Loading

NorbertGarfield commented Apr 13, 2022 •

edited

Loading