-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Remove git2
and hex
dependencies
#1992
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raskad
requested review from
Razican,
jasonwilliams,
HalidOdat,
RageKnify and
jedel1043
March 31, 2022 01:05
Test262 conformance changesVM implementation
|
Codecov Report
@@ Coverage Diff @@
## main #1992 +/- ##
=======================================
Coverage 45.90% 45.90%
=======================================
Files 206 206
Lines 17148 17148
=======================================
+ Hits 7871 7872 +1
+ Misses 9277 9276 -1
Continue to review full report at Codecov.
|
Benchmark for dda129fClick to view benchmark
|
jasonwilliams
approved these changes
Mar 31, 2022
jedel1043
approved these changes
Mar 31, 2022
bors r+ |
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Remove
[Merged by Bors] - Remove Mar 31, 2022
git2
and hex
dependenciesgit2
and hex
dependencies
Razican
added a commit
that referenced
this pull request
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the only use of the
git2
andhex
dependencies by reading the test262 submodule commit id directly from the.git
directory.Because
git2
depends on a lot of other crates, this removes a bunch of dependencies.