[Merged by Bors] - Fix panic on AST dump in JSON format #1959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the fields in AST structs were both 1. Arrays 2. Marked as 'flatten' This is illegal per serde docs (and doesn't really make sense). The fix is to remove the attribute. See: https://serde.rs/attr-flatten.html Fixes: #1920
Codecov Report
@@ Coverage Diff @@
## main #1959 +/- ##
=======================================
Coverage 45.87% 45.87%
=======================================
Files 206 206
Lines 17102 17102
=======================================
Hits 7846 7846
Misses 9256 9256
Continue to review full report at Codecov.
|
jedel1043
changed the title
raskad
added
bug
raskad
approved these changes
Mar 20, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 20, 2022
Some of the fields in AST structs were both 1. Arrays 2. Marked as 'flatten' This is illegal per serde docs (and doesn't really make sense). The fix is to remove the attribute. See: https://serde.rs/attr-flatten.html Fixes: #1920 Co-authored-by: Taras Boiko <[email protected]>
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Razican
pushed a commit
that referenced
this pull request
Jun 8, 2022
Some of the fields in AST structs were both 1. Arrays 2. Marked as 'flatten' This is illegal per serde docs (and doesn't really make sense). The fix is to remove the attribute. See: https://serde.rs/attr-flatten.html Fixes: #1920 Co-authored-by: Taras Boiko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the fields in AST structs were both
This is illegal per serde docs (and doesn't really make sense).
The fix is to remove the attribute.
See: https://serde.rs/attr-flatten.html
Fixes: #1920