-
-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Migrate to NPM and cleanup Playground #1951
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good, except for the wash dep update, which fails in clippy
i'm sure the Github/workflow files are using yarn too. Did you do a search for yarn references? Also you mentioned ESBuild couldn't be used because of top-level await, where was top level await being used? |
Forgot about that 😅, I'll fix it ASAP.
If it was in our code it would be easier to fix, but it's used by https://github.com/Tschrock/esbuild-plugin-wasm. I also tried to export the wasm build as |
I’d been keen to take a look at this when I get some time, I’ve used the esbuild wasm plugin and not had issues before. |
That's related to https://github.com/Tschrock/esbuild-plugin-wasm-pack. The cause is rustwasm/wasm-pack#642, since the plugin tries to run |
Test262 conformance changesVM implementation
|
Codecov Report
@@ Coverage Diff @@
## main #1951 +/- ##
=======================================
Coverage 45.87% 45.87%
=======================================
Files 206 206
Lines 17102 17102
=======================================
Hits 7846 7846
Misses 9256 9256 Continue to review full report at Codecov.
|
https://github.com/boa-dev/boa/blob/main/.github/workflows/release.yml#L29-L39 will need changing to the npm equivalent |
Fixed! I also decided to use node 14 since its |
Benchmark for 2fd4956Click to view benchmark
|
Benchmark for 6879882Click to view benchmark
|
Benchmark for c66cbd3Click to view benchmark
|
LGTM, agree with changing to node 16 |
Unrolled downgrade to v14, switched to |
Benchmark for 32ff1d7Click to view benchmark
|
Benchmark for 96fd628Click to view benchmark
|
Benchmark for 3ecdfbaClick to view benchmark
|
bors r+ |
This Pull Request closes #1912 by migrating to a NPM based build, hopefully making it easier to contribute to the Playground. Also, reduces the number of features of the editor, since most of them were support for other languages or features that don't make sense in a playground environment. This considerably reduces the number of fetched files per page load and the total size of the playground.
Pull request successfully merged into main. Build succeeded: |
This Pull Request closes #1912 by migrating to a NPM based build, hopefully making it easier to contribute to the Playground. Also, reduces the number of features of the editor, since most of them were support for other languages or features that don't make sense in a playground environment. This considerably reduces the number of fetched files per page load and the total size of the playground.
This Pull Request closes #1912 by migrating to a NPM based build, hopefully making it easier to contribute to the Playground.
Also, reduces the number of features of the editor, since most of them were support for other languages or features that don't make sense in a playground environment. This considerably reduces the number of fetched files per page load and the total size of the playground.