-
-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Implement destructing assignments for assignment expressions #1895
Conversation
Test262 conformance changesVM implementation
Fixed tests (491):
|
Codecov Report
@@ Coverage Diff @@
## main #1895 +/- ##
==========================================
- Coverage 46.36% 46.04% -0.33%
==========================================
Files 206 206
Lines 16824 17003 +179
==========================================
+ Hits 7801 7829 +28
- Misses 9023 9174 +151
Continue to review full report at Codecov.
|
Benchmark for 7d7c514Click to view benchmark
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! And the number of fixed tests also look good. Nice job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! :)
Benchmark for bad1dc0Click to view benchmark
|
bors r+ |
It changes the following: - Implement destructing assignments for assignment expressions
Pull request successfully merged into main. Build succeeded: |
It changes the following: