[Merged by Bors] - Reduced the size of AST nodes #1821
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Razican
added
performance
Razican
requested review from
jasonwilliams,
HalidOdat,
RageKnify,
raskad and
jedel1043
Test262 conformance changesVM implementation
|
Codecov Report
@@ Coverage Diff @@
## main #1821 +/- ##
==========================================
- Coverage 55.73% 55.71% -0.02%
==========================================
Files 201 201
Lines 17326 17326
==========================================
- Hits 9656 9654 -2
- Misses 7670 7672 +2
Continue to review full report at Codecov.
|
Benchmark for 5b08ad6Click to view benchmark
|
|
I'm actually pretty surprised that the benchmark are not clearly showing improvements, even though there might be some small ones. There is also one benchmark that shows a 18% worsening, which is worrying me. Maybe this is just due to the GitHub Actions uncertainty (no dedicated processing power, for instance). We should probably try to benchmark things locally or in a dedicated-core virtual server. |
|
@Razican have you tried running the profiler and looking at before and after? That may give you a deeper insight into what is going on. https://github.com/boa-dev/boa/blob/main/docs/profiling.md |
I ran the profiler locally and didn't see much difference. Then I ran benchmarks, and I could clearly see a consistent 2-6% improvement in the parser and a consistent and clear 1-2% improvement in the execution. The compiler was having a 0-1% improvement, but it was not very clear. I also checked this "Array creation (Execution)" benchmark and got a 1.8% improvement locally, so that 18% worsening is definitely not real. |
RageKnify
reviewed
Feb 6, 2022
RageKnify
approved these changes
Feb 6, 2022
Benchmark for ed38040Click to view benchmark
|
Benchmark for 004d648Click to view benchmark
|
Razican
force-pushed
the
node_optimization
branch
from
47324be to
12283eb
Compare
Benchmark for 4e3b45bClick to view benchmark
|
HalidOdat
approved these changes
Feb 7, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 7, 2022
This PR boxes the `Try` and `TaggedTemplate` nodes reducing the size of the `Node` structure from 88 to 56 bytes. This should improve performance in most cases, by adding another indirection with code with `try` and templates.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR boxes the
TryandTaggedTemplatenodes reducing the size of theNodestructure from 88 to 56 bytes. This should improve performance in most cases, by adding another indirection with code withtryand templates.