-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Adjust compile
and execute
to avoid clones
#1778
Conversation
Test262 conformance changesVM implementation
|
Codecov Report
@@ Coverage Diff @@
## main #1778 +/- ##
==========================================
- Coverage 55.72% 55.72% -0.01%
==========================================
Files 201 201
Lines 17336 17336
==========================================
- Hits 9661 9660 -1
- Misses 7675 7676 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should document somewhere that if the library users would like to execute a CodeBlock
more than once they should clone the Gc
instead of passing it to execute
directly.
I guess this can be added to the documentation of |
a09ebbc
to
ee2aef3
Compare
I added the relevant documentation, LGTM :) |
Fixed a typos in the docs. Looks good to merge. |
bors r+ |
It changes the following: - Adjust the `context` methods `compile` and `execute` to avoid clones on `StatementList` and `CodeBlock` Co-authored-by: raskad <[email protected]>
Pull request successfully merged into main. Build succeeded: |
compile
and execute
to avoid clonescompile
and execute
to avoid clones
It changes the following:
context
methodscompile
andexecute
to avoid clones onStatementList
andCodeBlock