Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(boa): bitwise not operation #1384

Merged
merged 5 commits into from
Jul 28, 2021
Merged

fix(boa): bitwise not operation #1384

merged 5 commits into from
Jul 28, 2021

Conversation

neeldug
Copy link
Contributor

@neeldug neeldug commented Jul 1, 2021

It changes the following:

  • follows spec more rigorously
  • todo: work out why hex bigint fails

@neeldug
Copy link
Contributor Author

neeldug commented Jul 1, 2021

Test262 conformance changes:

Test result master count PR count difference
Total 78,897 78,897 0
Passed 26,990 27,000 +10
Ignored 15,616 15,616 0
Failed 36,291 36,281 -10
Panics 0 0 0
Conformance 34.21% 34.22% +0.01%
Fixed tests: 
test/language/expressions/bitwise-not/S9.5_A2.2_T2.js [strict mode] (previously Failed)
test/language/expressions/bitwise-not/S9.5_A2.2_T2.js (previously Failed)
test/language/expressions/bitwise-not/bigint.js [strict mode] (previously Failed)
test/language/expressions/bitwise-not/bigint.js (previously Failed)
test/language/expressions/bitwise-not/S11.4.8_A3_T2.js [strict mode] (previously Failed)
test/language/expressions/bitwise-not/S11.4.8_A3_T2.js (previously Failed)
test/language/expressions/bitwise-not/S9.5_A2.1_T2.js [strict mode] (previously Failed)
test/language/expressions/bitwise-not/S9.5_A2.1_T2.js (previously Failed)
test/language/expressions/bitwise-not/S9.5_A2.3_T2.js [strict mode] (previously Failed)
test/language/expressions/bitwise-not/S9.5_A2.3_T2.js (previously Failed)

Currently failing tcs are bigint-primitive and ones involving eval

@Razican Razican added bug Something isn't working execution Issues or PRs related to code execution labels Jul 2, 2021
@Razican Razican added this to the v0.13.0 milestone Jul 2, 2021
Razican
Razican approved these changes Jul 2, 2021
View reviewed changes
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

neeldug added 2 commits July 25, 2021 15:58
@neeldug
fix(boa): bitwise not operation
41c7752 
- follows spec more rigorously
- todo: work out why hex bigint fails
mysteriously
@neeldug
simplify & document
1a5266f
@neeldug neeldug requested review from HalidOdat and Razican July 27, 2021 21:46
HalidOdat
HalidOdat reviewed Jul 27, 2021
View reviewed changes
boa/src/value/mod.rs Outdated Show resolved Hide resolved
@neeldug neeldug requested a review from HalidOdat July 28, 2021 00:38
@HalidOdat HalidOdat merged commit 330839d into boa-dev:master Jul 28, 2021
@neeldug neeldug deleted the fix-bitwise branch July 28, 2021 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HalidOdat HalidOdat HalidOdat approved these changes

@RageKnify RageKnify Awaiting requested review from RageKnify

@jasonwilliams jasonwilliams Awaiting requested review from jasonwilliams

@Razican Razican Awaiting requested review from Razican

Assignees
No one assigned
Labels
bug Something isn't working execution Issues or PRs related to code execution
Projects
None yet
Milestone
v0.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@neeldug @Razican @HalidOdat