Redesign bytecode virtual machine #1361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HalidOdat
added
enhancement
Benchmark for 247eb6dClick to view benchmark
|
Benchmark for 54fb08eClick to view benchmark
|
|
Looks good so far, and yes i was hoping to reduce the bytecodes down to actual codes rather than fat enums. Thanks for refactoring this. |
Benchmark for 725a2c8Click to view benchmark
|
Razican
changed the title
Benchmark for 5d799faClick to view benchmark
|
HalidOdat
requested review from
jasonwilliams,
RageKnify,
Razican,
0x7D2B,
Lan2u and
tofpie
Test262 conformance changes:
|
|
This is ready to review/merge :) I wanted to add more stuff like function/calls and catching error (both require a lot of change to the current execution scheme, call frames and stack unwinding). But I already added a lot in this PR, so I will leave this for separate PRs after this gets merged. Hopefully in the near future we will completely replace the AST walker executor. |
Benchmark for 62e7ae6Click to view benchmark
|
Benchmark for 9f20035Click to view benchmark
|
Benchmark for b1df807Click to view benchmark
|
Benchmark for bea70aaClick to view benchmark
|
Razican
reviewed
Jun 29, 2021
Benchmark for 8598a21Click to view benchmark
|
Razican
approved these changes
Jun 30, 2021
- Implemented Jump and JumpIfFalse opcodes - Implemented If in vm - Implement assign to identifiers - Implement JumpIfTrue opcode - Implemented short circuit operators - Implement while loop - Implement do-while loop - Pop expressions - Split compilation for epression and statement - simplify boolean compilation - Implement loop break and continue with labels - Implement getting property from object - Implement setting object properties - Implement binary assign - Implement throw - Split variable names from literals - Implement conditional operator - Implement array expressions without spread - Implement some unary operators - Add accessor types - Implement this - Add opcode for pushing rationals - Implement instanceof operator
Benchmark for 25179caClick to view benchmark
|
|
Will take a look today/tomorrow hopefully |
jasonwilliams
approved these changes
Jul 2, 2021
|
Lets merge this, so other features are not blocked :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous virtual machine was not really a bytecode vm, since did not interpret bytecode, rather it interpreted and array of fat enums, while this is easier to implement is has bad space efficiency (also bad performance), one instruction was 32 bytes (on 64-bit machine) and consequently all other instructions where 32 bytes.
So for this code:
It would take 64 bytes. But now with an actual bytecode vm we only need 2 bytes.
Also implemented some other stuff:
If-elsewhiledo-whilebreakcontinue&&,||,??)?:)[1, 2, 3, 4])thisinstanceofoperator