fix(boa): 15.4.4.19-8-c-ii-1.js #1351

neeldug · 2021-06-20T19:42:54Z

This Pull Request fixes/closes #1306.

It changes the following:

skips undefined values on callback

todo: speedup execution of construct array, currently stalls for large arrays of mainly undefined values.

neeldug · 2021-06-20T19:44:17Z

@Razican this will still stall on execution due to the utility function for creating array objects being super slow, not totally familiar with JS array objects and so not too sure if there's a way to avoid iterating through the entire array.

The specific call that's taking a huge amount of time, considering the required iterations are 1M can be found here.

Razican · 2021-06-21T07:38:43Z

Test262 conformance changes:

Test result	master count	PR count	difference
Total	78,897	78,897	0
Passed	28,204	28,270	+66
Ignored	15,616	15,614	-2
Failed	35,077	35,013	-64
Panics	2	2	0
Conformance	35.75%	35.83%	+0.08%

Fixed tests:

test/built-ins/Array/prototype/map/15.4.4.19-8-b-14.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-8-b-14.js (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-1-4.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-1-4.js (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-1-2.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-1-2.js (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-1-11.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-1-11.js (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-8-3.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-8-3.js (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-8-5.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-8-5.js (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-1-6.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-1-6.js (previously Failed)
test/built-ins/Array/prototype/map/create-species-non-ctor.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/map/create-species-non-ctor.js (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-8-c-ii-12.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-8-c-ii-12.js (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-1-14.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-1-14.js (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-8-c-ii-11.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-8-c-ii-11.js (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-8-b-10.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-8-b-10.js (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-4-15.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-4-15.js (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-8-b-8.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-8-b-8.js (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-1-10.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-1-10.js (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-8-c-ii-6.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-8-c-ii-6.js (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-1-1.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-1-1.js (previously Failed)
test/built-ins/Array/prototype/map/create-proto-from-ctor-realm-non-array.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/map/create-proto-from-ctor-realm-non-array.js (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-1-9.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-1-9.js (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-1-13.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-1-13.js (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-1-8.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-1-8.js (previously Failed)
test/built-ins/Array/prototype/map/create-ctor-non-object.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/map/create-ctor-non-object.js (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-4-1.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-4-1.js (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-8-c-ii-1.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/map/15.4.4.19-8-c-ii-1.js (previously Ignored)
test/built-ins/Array/prototype/map/create-species-poisoned.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/map/create-species-poisoned.js (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-8-b-3.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-8-b-3.js (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-8-b-1.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-8-b-1.js (previously Failed)
test/built-ins/Array/prototype/map/create-ctor-poisoned.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/map/create-ctor-poisoned.js (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-8-b-9.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-8-b-9.js (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-8-c-ii-19.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-8-c-ii-19.js (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-8-c-ii-13.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-8-c-ii-13.js (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-8-9.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-8-9.js (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-8-c-ii-23.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-8-c-ii-23.js (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-8-4.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/map/15.4.4.19-8-4.js (previously Failed)

Broken tests:

test/built-ins/Array/prototype/map/create-proto-from-ctor-realm-array.js [strict mode] (previously Passed)
test/built-ins/Array/prototype/map/create-proto-from-ctor-realm-array.js (previously Passed)

Razican · 2021-06-21T07:39:44Z

@Razican this will still stall on execution due to the utility function for creating array objects being super slow, not totally familiar with JS array objects and so not too sure if there's a way to avoid iterating through the entire array.

The specific call that's taking a huge amount of time, considering the required iterations are 1M can be found here.

We can still ignore it until we figure this out. Give a look to the results, though, since many tests seem failing.

neeldug · 2021-06-22T01:00:49Z

@RageKnify @Razican fixed it for all of map now, should be in line with spec, overall map conformance is 89.55%, which I believe is higher than before.

Razican · 2021-06-22T09:57:56Z

@RageKnify @Razican fixed it for all of map now, should be in line with spec, overall map conformance is 89.55%, which I believe is higher than before.

Great, thank you! I updated conformance numbers, and it seems there is only one extra broken test. Could you check why?

neeldug · 2021-06-22T13:40:24Z

Great, thank you! I updated conformance numbers, and it seems there is only one extra broken test. Could you check why?

Pulled it into debugger, the text shows up as "Uncaught "TypeError": "Symbol.species must be a constructor"", which is actually expected, as before Boa didn't use the specified array_species_create function, which currently skips step 4, as seen here. I could implement this here, or on a separate PR since it might end up being more involved, not really too sure about how realms work in general. But either way, I think that this PR should be good to go for merging. @Razican

Looking more into this, it would require this to be implemented too, started trying to work on it at the moment, but it's starting to become more heavier than I think is within the bounds of this PR.

neeldug · 2021-06-26T19:33:10Z

@Razican I think above specifies it, it's essentially due to Realms being unimplemented under array_species_create as I mentioned before. I believe this functionality wasn't present in the previous version but was rather a false positive, or a seeming pass. I think this PR is ready for merge.

HalidOdat

Look good to me! :)

Just needs a rebase

jasonwilliams

just needs a rebase

- skips undefined values on callback - formats Closes boa-dev#1306

neeldug force-pushed the fix-map branch from cf5ffbf to 6a24826 Compare June 21, 2021 20:50

This comment has been minimized.

Sign in to view

Razican requested review from RageKnify, Razican, HalidOdat and jasonwilliams June 27, 2021 08:38

Razican approved these changes Jun 27, 2021

View reviewed changes

neeldug mentioned this pull request Jun 27, 2021

feat(boa): adds splice method #1365

Merged

HalidOdat approved these changes Jul 21, 2021

View reviewed changes

HalidOdat added the builtins PRs and Issues related to builtins/intrinsics label Jul 21, 2021

HalidOdat added this to the v0.13.0 milestone Jul 21, 2021

neeldug force-pushed the fix-map branch 2 times, most recently from c5515a0 to 9ced066 Compare July 21, 2021 19:13

neeldug requested review from HalidOdat and Razican July 21, 2021 19:21

jasonwilliams approved these changes Jul 23, 2021

View reviewed changes

neeldug added 7 commits July 23, 2021 22:01

fix(boa): 15.4.4.19-8-c-ii-1.js

25ce885

- skips undefined values on callback - formats Closes boa-dev#1306

add map callbackfn check whether callable

f9de7e8

major rewrite of map function for es compliance

38aa8f7

fix testcase 15.4.4.19-8-c-ii-1.js

5d1c0d2

fmt

215c810

add range error in array constructor

7087dc5

fix clippy errors & fmt

9819d64

neeldug force-pushed the fix-map branch from 6bc04ae to d4deca0 Compare July 23, 2021 21:24

neeldug requested a review from jasonwilliams July 23, 2021 21:25

rebase

fbecaa0

neeldug force-pushed the fix-map branch from d4deca0 to fbecaa0 Compare July 23, 2021 21:26

Razican merged commit a4a76fe into boa-dev:master Jul 24, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(boa): 15.4.4.19-8-c-ii-1.js #1351

fix(boa): 15.4.4.19-8-c-ii-1.js #1351

neeldug commented Jun 20, 2021

neeldug commented Jun 20, 2021 •

edited

Loading

Razican commented Jun 21, 2021 •

edited

Loading

Razican commented Jun 21, 2021

This comment has been minimized.

neeldug commented Jun 22, 2021

Razican commented Jun 22, 2021

neeldug commented Jun 22, 2021 •

edited

Loading

neeldug commented Jun 26, 2021

HalidOdat left a comment

jasonwilliams left a comment

fix(boa): 15.4.4.19-8-c-ii-1.js #1351

fix(boa): 15.4.4.19-8-c-ii-1.js #1351

Conversation

neeldug commented Jun 20, 2021

neeldug commented Jun 20, 2021 • edited Loading

Razican commented Jun 21, 2021 • edited Loading

Test262 conformance changes:

Razican commented Jun 21, 2021

This comment has been minimized.

neeldug commented Jun 22, 2021

Razican commented Jun 22, 2021

neeldug commented Jun 22, 2021 • edited Loading

neeldug commented Jun 26, 2021

HalidOdat left a comment

Choose a reason for hiding this comment

jasonwilliams left a comment

Choose a reason for hiding this comment

neeldug commented Jun 20, 2021 •

edited

Loading

Razican commented Jun 21, 2021 •

edited

Loading

neeldug commented Jun 22, 2021 •

edited

Loading