AST nodes now have spans #1295
Closed
AST nodes now have spans #1295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Razican
added
enhancement
Razican
force-pushed
the
feature/node_span
branch
2 times, most recently
from
819fea1 to
3441ce3
Compare
Razican
force-pushed
the
feature/node_span
branch
from
3441ce3 to
04f1be4
Compare
Razican
force-pushed
the
feature/node_span
branch
2 times, most recently
from
da6b113 to
2ceee3c
Compare
Razican
force-pushed
the
feature/node_span
branch
2 times, most recently
from
0ccda0c to
887a2f1
Compare
Razican
force-pushed
the
feature/node_span
branch
from
887a2f1 to
639f675
Compare
|
I will close this, since this would require a huge rebase, and it will be easier to just start over. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #300.
It changes the following:
Nodenow has aspan, that will start on the beginning of the first token and end on the end of the last token.NodeKindenumeration, that is equivalent to the oldNode.Self, among other thingsSpanandPositionnow implement theDefaulttrait. The default position is to start on line 1, character 1. A default span starts and ends on that position.as_ref().to_vec()references toVectoclone(), that should improve performance there a bitIn general, I expect that these changes will have a negative performance impact. Nevertheless, this is needed to allow better interactivity with the parser. This is still WIP, and still doesn't build (we are still missing changes in most parsers, I'm slowly working towards it).