Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test262 comment formatting #1293

Merged
merged 1 commit into from
May 29, 2021
Merged

Fix test262 comment formatting #1293

merged 1 commit into from
May 29, 2021

Conversation

0x7D2B
Copy link
Contributor

@0x7D2B 0x7D2B commented May 29, 2021

This pull request fixes code tags not being applied to test262 comments correctly.

@github-actions
Copy link

Test262 conformance changes:

Test result master count PR count difference
Total 78,873 78,873 0
Passed 26,665 26,665 0
Ignored 15,604 15,604 0
Failed 36,604 36,604 0
Panics 14 14 0
Conformance 33.81% 33.81% 0.00%

@0x7D2B 0x7D2B merged commit e7ffe7f into master May 29, 2021
@github-actions
Copy link

Benchmark for c6bfba9

Click to view benchmark
Test PR Benchmark Master Benchmark %
Arithmetic operations (Execution) 308.1±3.53ns 301.3±0.14ns +2.26%
Arithmetic operations (Full) 229.3±0.29µs 230.0±0.24µs -0.30%
Array access (Execution) 5.3±0.02µs 5.4±0.01µs -1.85%
Array access (Full) 250.8±0.33µs 248.4±0.52µs +0.97%
Array creation (Execution) 2.4±0.00ms 2.4±0.01ms 0.00%
Array creation (Full) 2.8±0.00ms 2.8±0.00ms 0.00%
Array pop (Execution) 777.5±3.17µs 778.8±4.31µs -0.17%
Array pop (Full) 1206.8±2.77µs 1209.1±1.69µs -0.19%
Boolean Object Access (Execution) 4.4±0.00µs 4.4±0.00µs 0.00%
Boolean Object Access (Full) 242.8±0.30µs 243.8±0.23µs -0.41%
Clean js (Execution) 513.7±5.41µs 512.8±2.05µs +0.18%
Clean js (Full) 790.2±2.23µs 791.5±3.32µs -0.16%
Clean js (Parser) 36.4±0.05µs 36.1±0.03µs +0.83%
Create Realm 361.2±0.22ns 359.3±0.41ns +0.53%
Dynamic Object Property Access (Execution) 4.4±0.02µs 4.4±0.02µs 0.00%
Dynamic Object Property Access (Full) 248.0±0.27µs 245.7±0.29µs +0.94%
Expression (Parser) 6.2±0.01µs 6.1±0.00µs +1.64%
Fibonacci (Execution) 679.7±0.99µs 679.9±1.05µs -0.03%
Fibonacci (Full) 950.9±0.79µs 948.4±3.60µs +0.26%
For loop (Execution) 18.4±0.06µs 18.4±0.02µs 0.00%
For loop (Full) 260.8±0.48µs 258.5±0.61µs +0.89%
For loop (Parser) 17.4±0.02µs 17.3±0.04µs +0.58%
Goal Symbols (Parser) 12.2±0.02µs 12.2±0.01µs 0.00%
Hello World (Parser) 3.4±0.01µs 3.4±0.00µs 0.00%
Long file (Parser) 715.4±6.85ns 723.8±7.20ns -1.16%
Mini js (Execution) 459.6±2.31µs 460.1±2.36µs -0.11%
Mini js (Full) 737.7±2.81µs 739.5±3.36µs -0.24%
Mini js (Parser) 31.7±0.02µs 31.6±0.04µs +0.32%
Number Object Access (Execution) 3.4±0.01µs 3.4±0.00µs 0.00%
Number Object Access (Full) 240.4±1.62µs 239.7±0.44µs +0.29%
Object Creation (Execution) 3.7±0.00µs 3.8±0.02µs -2.63%
Object Creation (Full) 240.1±0.32µs 241.4±0.23µs -0.54%
RegExp (Execution) 9.4±0.02µs 9.3±0.03µs +1.08%
RegExp (Full) 253.1±0.79µs 254.4±0.56µs -0.51%
RegExp Literal (Execution) 9.3±0.03µs 9.3±0.02µs 0.00%
RegExp Literal (Full) 253.3±0.35µs 252.1±0.31µs +0.48%
RegExp Literal Creation (Execution) 8.1±0.02µs 8.1±0.02µs 0.00%
RegExp Literal Creation (Full) 248.0±0.31µs 246.9±0.32µs +0.45%
Static Object Property Access (Execution) 4.0±0.01µs 4.0±0.01µs 0.00%
Static Object Property Access (Full) 245.5±0.34µs 245.8±0.30µs -0.12%
String Object Access (Execution) 6.0±0.01µs 6.1±0.01µs -1.64%
String Object Access (Full) 245.4±0.30µs 247.1±0.31µs -0.69%
String comparison (Execution) 5.5±0.01µs 5.5±0.01µs 0.00%
String comparison (Full) 243.2±0.29µs 245.4±0.27µs -0.90%
String concatenation (Execution) 4.5±0.01µs 4.5±0.01µs 0.00%
String concatenation (Full) 237.9±0.27µs 241.8±0.29µs -1.61%
String copy (Execution) 3.3±0.03µs 3.4±0.01µs -2.94%
String copy (Full) 234.2±3.48µs 234.6±0.52µs -0.17%
Symbols (Execution) 2.9±0.01µs 2.9±0.00µs 0.00%
Symbols (Full) 228.2±0.34µs 230.0±0.40µs -0.78%

@RageKnify RageKnify deleted the fix/test262-formatting branch May 31, 2021 17:35
@RageKnify RageKnify added this to the v0.12.0 milestone May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants