Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed a bunch of ignored tests that we no longer need to ignore #1240

Merged
merged 1 commit into from
May 9, 2021

Conversation

Razican
Copy link
Member

@Razican Razican commented May 8, 2021

Things have improved a lot in the last months. This allows us to remove some ignored tests from the ignore list, so that they can actually be tested. We were even passing some of them!

@Razican Razican added the test Issues and PRs related to the tests. label May 8, 2021
@Razican Razican added this to the v0.12.0 milestone May 8, 2021
@github-actions
Copy link

github-actions bot commented May 8, 2021

Test262 conformance changes:

Test result master count PR count difference
Total 78,497 78,497 0
Passed 25,537 25,551 +14
Ignored 15,587 15,513 -74
Failed 37,373 37,433 +60
Panics 13 13 0
Conformance 32.53 32.55 +0.02%

@github-actions
Copy link

github-actions bot commented May 8, 2021

Benchmark for dc528aa

Click to view benchmark
Test PR Benchmark Master Benchmark %
Arithmetic operations (Execution) 340.9±11.87ns 329.1±10.62ns +3.59%
Arithmetic operations (Full) 243.8±11.36µs 242.8±13.30µs +0.41%
Array access (Execution) 6.1±0.33µs 6.0±0.15µs +1.67%
Array access (Full) 266.3±9.76µs 266.3±9.85µs 0.00%
Array creation (Execution) 2.6±0.08ms 2.6±0.10ms 0.00%
Array creation (Full) 2.8±0.07ms 2.8±0.06ms 0.00%
Array pop (Execution) 823.2±24.70µs 824.2±22.62µs -0.12%
Array pop (Full) 1306.8±54.88µs 1290.8±139.58µs +1.24%
Boolean Object Access (Execution) 5.2±0.22µs 5.1±0.19µs +1.96%
Boolean Object Access (Full) 262.4±11.84µs 260.5±11.70µs +0.73%
Clean js (Execution) 633.0±38.61µs 629.1±20.66µs +0.62%
Clean js (Full) 905.3±32.23µs 891.9±31.97µs +1.50%
Clean js (Parser) 38.6±1.79µs 38.7±1.73µs -0.26%
Create Realm 402.0±15.76ns 404.2±19.43ns -0.54%
Dynamic Object Property Access (Execution) 5.1±0.26µs 5.1±0.15µs 0.00%
Dynamic Object Property Access (Full) 263.8±12.32µs 267.6±12.82µs -1.42%
Expression (Parser) 6.2±0.27µs 6.1±0.25µs +1.64%
Fibonacci (Execution) 831.6±48.68µs 823.6±35.75µs +0.97%
Fibonacci (Full) 1057.2±38.80µs 1054.8±41.19µs +0.23%
For loop (Execution) 21.5±1.36µs 21.5±1.62µs 0.00%
For loop (Full) 279.7±11.35µs 283.0±14.00µs -1.17%
For loop (Parser) 18.5±1.89µs 18.3±0.63µs +1.09%
Goal Symbols (Parser) 12.6±0.46µs 12.8±0.59µs -1.56%
Hello World (Parser) 3.4±0.13µs 3.5±0.22µs -2.86%
Long file (Parser) 722.6±29.00ns 718.7±28.37ns +0.54%
Mini js (Execution) 558.6±20.34µs 558.5±18.05µs +0.02%
Mini js (Full) 839.7±31.27µs 836.3±38.94µs +0.41%
Mini js (Parser) 33.7±1.61µs 33.8±1.02µs -0.30%
Number Object Access (Execution) 3.9±0.13µs 4.0±0.14µs -2.50%
Number Object Access (Full) 259.0±13.31µs 256.6±8.68µs +0.94%
Object Creation (Execution) 4.3±0.14µs 4.3±0.18µs 0.00%
Object Creation (Full) 263.5±15.75µs 257.0±8.79µs +2.53%
RegExp (Execution) 10.8±0.61µs 10.8±0.72µs 0.00%
RegExp (Full) 263.8±7.12µs 267.5±17.94µs -1.38%
RegExp Literal (Execution) 10.7±0.52µs 10.6±0.82µs +0.94%
RegExp Literal (Full) 269.6±9.19µs 271.2±12.20µs -0.59%
RegExp Literal Creation (Execution) 9.2±0.41µs 9.4±0.38µs -2.13%
RegExp Literal Creation (Full) 263.1±9.44µs 264.7±9.98µs -0.60%
Static Object Property Access (Execution) 4.5±0.18µs 4.6±0.19µs -2.17%
Static Object Property Access (Full) 264.9±10.62µs 262.2±23.73µs +1.03%
String Object Access (Execution) 7.0±0.24µs 7.1±0.22µs -1.41%
String Object Access (Full) 261.7±9.90µs 259.3±7.24µs +0.93%
String comparison (Execution) 6.2±0.26µs 6.3±0.29µs -1.59%
String comparison (Full) 266.6±13.70µs 263.2±10.21µs +1.29%
String concatenation (Execution) 5.2±0.16µs 5.3±0.17µs -1.89%
String concatenation (Full) 259.9±14.26µs 257.4±10.80µs +0.97%
String copy (Execution) 4.0±0.14µs 4.0±0.18µs 0.00%
String copy (Full) 251.4±10.88µs 254.2±19.55µs -1.10%
Symbols (Execution) 3.3±0.15µs 3.3±0.12µs 0.00%
Symbols (Full) 236.1±5.80µs 237.3±13.52µs -0.51%

@RageKnify RageKnify merged commit 143dbac into master May 9, 2021
@RageKnify RageKnify deleted the unignore branch May 9, 2021 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants