VM Trace output fixes #1035 #1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1048 +/- ##
==========================================
- Coverage 58.69% 58.56% -0.14%
==========================================
Files 176 176
Lines 12389 12516 +127
==========================================
+ Hits 7272 7330 +58
- Misses 5117 5186 +69
Continue to review full report at Codecov.
|
RageKnify
approved these changes
Jan 12, 2021
Razican
reviewed
Jan 12, 2021
Comment on lines
+69
to
+81
| while self.idx < self.instructions.len() { | ||
| if self.is_trace { | ||
| self.trace_print(false); | ||
| }; | ||
|
|
||
| while idx < self.instructions.len() { | ||
| let _timer = | ||
| BoaProfiler::global().start_event(&self.instructions[idx].to_string(), "vm"); | ||
| match self.instructions[idx] { | ||
| BoaProfiler::global().start_event(&self.instructions[self.idx].to_string(), "vm"); | ||
| match self.instructions[self.idx] { |
There was a problem hiding this comment.
Here I see we are iterating and using the index to retrieve the instruction. Couldn't we do this with iterators?
There was a problem hiding this comment.
I’m going to merge and come back to this
Razican
pushed a commit
that referenced
this pull request
May 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the JS
Output is:
Currently this is on by default.
Preferably we would pass
--traceto the cli to get this output, similar to other JS Cli's.This would mean needing to add a trace option to
eval()here https://github.com/boa-dev/boa/blob/master/boa/src/context.rs#L751