Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove InterpreterState from Context #1545

Closed
jedel1043 opened this issue Aug 31, 2021 · 2 comments
Closed

Remove InterpreterState from Context #1545

jedel1043 opened this issue Aug 31, 2021 · 2 comments
Labels
ast Issue surrounding the abstract syntax tree enhancement New feature or request execution Issues or PRs related to code execution

Comments

@jedel1043
Copy link
Member

jedel1043 commented Aug 31, 2021 •
edited
Loading

Related discussion on #1541.

Follows from #1544.

After returning every corresponding CompletionRecord in the spec, we can remove InterpreterState; at this point CompletionRecord should manage the execution state of its Node, so an additional InterpreterState should be unnecessary.

This feature is being developed in the https://github.com/boa-dev/boa/tree/feature/completion_records branch.
@jedel1043 jedel1043 added enhancement New feature or request execution Issues or PRs related to code execution ast Issue surrounding the abstract syntax tree labels Aug 31, 2021
@Razican
Copy link
Member

Razican commented Jan 23, 2022

This needs to be reviewed for the VM branch

@jedel1043
Copy link
Member Author

Closing since the VM now manages this using the FinallyReturn type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ast Issue surrounding the abstract syntax tree enhancement New feature or request execution Issues or PRs related to code execution
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Razican @jedel1043