Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Obtain the CompletionRecord of every AST node evaluation #1544

Closed
jedel1043 opened this issue Aug 31, 2021 · 1 comment
Closed

Obtain the CompletionRecord of every AST node evaluation #1544

jedel1043 opened this issue Aug 31, 2021 · 1 comment
Labels
ast Issue surrounding the abstract syntax tree enhancement New feature or request execution Issues or PRs related to code execution

Comments

@jedel1043
Copy link
Member

jedel1043 commented Aug 31, 2021 •
edited
Loading

Related discussion on #1541.

Follows from #1543.

We need to extensively search the language evaluation spec to find instances of CompletionRecords that should be returned.

This feature is being developed in the https://github.com/boa-dev/boa/tree/feature/completion_records branch.
@jedel1043 jedel1043 added ast Issue surrounding the abstract syntax tree enhancement New feature or request execution Issues or PRs related to code execution labels Aug 31, 2021
@jedel1043 jedel1043 mentioned this issue Aug 31, 2021
Closed
@jedel1043 jedel1043 mentioned this issue Sep 8, 2021
Closed
@jedel1043 jedel1043 mentioned this issue Feb 26, 2023
Closed
@jedel1043
Copy link
Member Author

Closing in favour of the current implementation. We can revisit this if we reassess that a more spec-compliant design is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ast Issue surrounding the abstract syntax tree enhancement New feature or request execution Issues or PRs related to code execution
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jedel1043