Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Added a bit more integer operation consistency to ByteDataBlock creat…
…ion (#2272) This Pull Request fixes a potential overflow when trying to convert a `u64` into a `usize` and then trying to create a byte data block. Related to this, we seem to be using a `u64` and `i64` as a general approach for an "integer", but ECMAScript doesn't have bounds for them, so they could be as big as infinite. Should we use `u128` and `i128` to have a bigger range? This would add a performance penalty, though, and we don't have 128-bit platforms usually, so the benefit would probably be minimal, at least when trying to allocate.
- Loading branch information