Fix docs

boa_engine/src/builtins/error/aggregate.rs

@@ -22,7 +22,7 @@ use crate::{
 };
 use boa_profiler::Profiler;
 
-use super::{Error, ErrorKind};
+use super::{Error, ErrorObject};
 
 #[derive(Debug, Clone, Copy)]
 pub(crate) struct AggregateError;
@@ -85,7 +85,7 @@ impl BuiltInConstructor for AggregateError {
         let o = JsObject::from_proto_and_data_with_shared_shape(
             context.root_shape(),
             prototype,
-            ErrorKind::Aggregate,
+            ErrorObject::Aggregate,
         );
 
         // 3. If message is not undefined, then

boa_engine/src/builtins/error/eval.rs

@@ -23,7 +23,7 @@ use crate::{
 };
 use boa_profiler::Profiler;
 
-use super::{Error, ErrorKind};
+use super::{Error, ErrorObject};
 
 /// JavaScript `EvalError` implementation.
 #[derive(Debug, Clone, Copy)]
@@ -84,7 +84,7 @@ impl BuiltInConstructor for EvalError {
         let o = JsObject::from_proto_and_data_with_shared_shape(
             context.root_shape(),
             prototype,
-            ErrorKind::Eval,
+            ErrorObject::Eval,
         );
 
         // 3. If message is not undefined, then

boa_engine/src/builtins/error/mod.rs

@@ -45,7 +45,7 @@ pub(crate) use self::uri::UriError;
 
 use super::{BuiltInBuilder, BuiltInConstructor, IntrinsicObject};
 
-/// The kind of a `NativeError` object, per the [ECMAScript spec][spec].
+/// A `NativeError` object, per the [ECMAScript spec][spec].
 ///
 /// This is used internally to convert between [`JsObject`] and
 /// [`JsNativeError`] correctly, but it can also be used to manually create `Error`
@@ -59,7 +59,8 @@ use super::{BuiltInBuilder, BuiltInConstructor, IntrinsicObject};
 /// [spec]: https://tc39.es/ecma262/#sec-error-objects
 #[derive(Debug, Copy, Clone, Eq, PartialEq, Trace, Finalize, JsData)]
 #[boa_gc(empty_trace)]
-pub enum ErrorKind {
+#[non_exhaustive]
+pub enum ErrorObject {
     /// The `AggregateError` object type.
     ///
     /// More information:
@@ -180,7 +181,7 @@ impl BuiltInConstructor for Error {
         let o = JsObject::from_proto_and_data_with_shared_shape(
             context.root_shape(),
             prototype,
-            ErrorKind::Error,
+            ErrorObject::Error,
         );
 
         // 3. If message is not undefined, then

boa_engine/src/builtins/error/range.rs

@@ -21,7 +21,7 @@ use crate::{
 };
 use boa_profiler::Profiler;
 
-use super::{Error, ErrorKind};
+use super::{Error, ErrorObject};
 
 /// JavaScript `RangeError` implementation.
 #[derive(Debug, Clone, Copy)]
@@ -82,7 +82,7 @@ impl BuiltInConstructor for RangeError {
         let o = JsObject::from_proto_and_data_with_shared_shape(
             context.root_shape(),
             prototype,
-            ErrorKind::Range,
+            ErrorObject::Range,
         );
 
         // 3. If message is not undefined, then

boa_engine/src/builtins/error/reference.rs

@@ -21,7 +21,7 @@ use crate::{
 };
 use boa_profiler::Profiler;
 
-use super::{Error, ErrorKind};
+use super::{Error, ErrorObject};
 
 #[derive(Debug, Clone, Copy)]
 pub(crate) struct ReferenceError;
@@ -84,7 +84,7 @@ impl BuiltInConstructor for ReferenceError {
         let o = JsObject::from_proto_and_data_with_shared_shape(
             context.root_shape(),
             prototype,
-            ErrorKind::Reference,
+            ErrorObject::Reference,
         );
 
         // 3. If message is not undefined, then

boa_engine/src/builtins/error/syntax.rs

@@ -23,7 +23,7 @@ use crate::{
 };
 use boa_profiler::Profiler;
 
-use super::{Error, ErrorKind};
+use super::{Error, ErrorObject};
 
 /// JavaScript `SyntaxError` implementation.
 #[derive(Debug, Clone, Copy)]
@@ -87,7 +87,7 @@ impl BuiltInConstructor for SyntaxError {
         let o = JsObject::from_proto_and_data_with_shared_shape(
             context.root_shape(),
             prototype,
-            ErrorKind::Syntax,
+            ErrorObject::Syntax,
         );
 
         // 3. If message is not undefined, then

boa_engine/src/builtins/error/type.rs

@@ -29,7 +29,7 @@ use crate::{
 };
 use boa_profiler::Profiler;
 
-use super::{Error, ErrorKind};
+use super::{Error, ErrorObject};
 
 /// JavaScript `TypeError` implementation.
 #[derive(Debug, Clone, Copy)]
@@ -90,7 +90,7 @@ impl BuiltInConstructor for TypeError {
         let o = JsObject::from_proto_and_data_with_shared_shape(
             context.root_shape(),
             prototype,
-            ErrorKind::Type,
+            ErrorObject::Type,
         );
 
         // 3. If message is not undefined, then

boa_engine/src/builtins/error/uri.rs

@@ -22,7 +22,7 @@ use crate::{
 };
 use boa_profiler::Profiler;
 
-use super::{Error, ErrorKind};
+use super::{Error, ErrorObject};
 
 /// JavaScript `URIError` implementation.
 #[derive(Debug, Clone, Copy)]
@@ -83,7 +83,7 @@ impl BuiltInConstructor for UriError {
         let o = JsObject::from_proto_and_data_with_shared_shape(
             context.root_shape(),
             prototype,
-            ErrorKind::Uri,
+            ErrorObject::Uri,
         );
 
         // 3. If message is not undefined, then

boa_engine/src/builtins/object/mod.rs

@@ -16,7 +16,7 @@
 use std::ops::Deref;
 
 use super::{
-    error::ErrorKind, Array, BuiltInBuilder, BuiltInConstructor, Date, IntrinsicObject, RegExp,
+    error::ErrorObject, Array, BuiltInBuilder, BuiltInConstructor, Date, IntrinsicObject, RegExp,
 };
 use crate::{
     builtins::{map, BuiltInObject},
@@ -845,7 +845,7 @@ impl OrdinaryObject {
             } else if o.is_callable() {
                 // 7. Else if O has a [[Call]] internal method, let builtinTag be "Function".
                 utf16!("Function")
-            } else if o.is::<ErrorKind>() {
+            } else if o.is::<ErrorObject>() {
                 // 8. Else if O has an [[ErrorData]] internal slot, let builtinTag be "Error".
                 utf16!("Error")
             } else if o.is::<bool>() {

boa_engine/src/class.rs

@@ -11,12 +11,12 @@
 //! #    class::{Class, ClassBuilder},
 //! #    Context, JsResult, JsValue,
 //! #    JsArgs, Source, JsObject, js_string,
-//! #    JsNativeError,
+//! #    JsNativeError, JsData,
 //! # };
 //! # use boa_gc::{Finalize, Trace};
 //! #
 //! // Can also be a struct containing `Trace` types.
-//! #[derive(Debug, Trace, Finalize)]
+//! #[derive(Debug, Trace, Finalize, JsData)]
 //! enum Animal {
 //!     Cat,
 //!     Dog,

boa_engine/src/error.rs

@@ -3,7 +3,7 @@
 use std::{error, fmt};
 
 use crate::{
-    builtins::{error::ErrorKind, Array},
+    builtins::{error::ErrorObject, Array},
     js_string,
     object::JsObject,
     property::PropertyDescriptor,
@@ -182,12 +182,13 @@ impl JsError {
     ///
     /// ```rust
     /// # use boa_engine::{Context, JsError, JsNativeError};
+    /// # use boa_engine::builtins::error::ErrorObject;
     /// let context = &mut Context::default();
     /// let error: JsError =
     ///     JsNativeError::eval().with_message("invalid script").into();
     /// let error_val = error.to_opaque(context);
     ///
-    /// assert!(error_val.as_object().unwrap().borrow().is_error());
+    /// assert!(error_val.as_object().unwrap().is::<ErrorObject>());
     /// ```
     pub fn to_opaque(&self, context: &mut Context) -> JsValue {
         match &self.inner {
@@ -242,7 +243,7 @@ impl JsError {
                     .as_object()
                     .ok_or_else(|| TryNativeError::NotAnErrorObject(val.clone()))?;
                 let error = *obj
-                    .downcast_ref::<ErrorKind>()
+                    .downcast_ref::<ErrorObject>()
                     .ok_or_else(|| TryNativeError::NotAnErrorObject(val.clone()))?;
 
                 let try_get_property = |key: JsString, name, context: &mut Context| {
@@ -275,14 +276,14 @@ impl JsError {
                 let cause = try_get_property(js_string!("cause"), "cause", context)?;
 
                 let kind = match error {
-                    ErrorKind::Error => JsNativeErrorKind::Error,
-                    ErrorKind::Eval => JsNativeErrorKind::Eval,
-                    ErrorKind::Type => JsNativeErrorKind::Type,
-                    ErrorKind::Range => JsNativeErrorKind::Range,
-                    ErrorKind::Reference => JsNativeErrorKind::Reference,
-                    ErrorKind::Syntax => JsNativeErrorKind::Syntax,
-                    ErrorKind::Uri => JsNativeErrorKind::Uri,
-                    ErrorKind::Aggregate => {
+                    ErrorObject::Error => JsNativeErrorKind::Error,
+                    ErrorObject::Eval => JsNativeErrorKind::Eval,
+                    ErrorObject::Type => JsNativeErrorKind::Type,
+                    ErrorObject::Range => JsNativeErrorKind::Range,
+                    ErrorObject::Reference => JsNativeErrorKind::Reference,
+                    ErrorObject::Syntax => JsNativeErrorKind::Syntax,
+                    ErrorObject::Uri => JsNativeErrorKind::Uri,
+                    ErrorObject::Aggregate => {
                         let errors = obj.get(utf16!("errors"), context).map_err(|e| {
                             TryNativeError::InaccessibleProperty {
                                 property: "errors",
@@ -892,12 +893,13 @@ impl JsNativeError {
     ///
     /// ```rust
     /// # use boa_engine::{Context, JsError, JsNativeError, js_string};
+    /// # use boa_engine::builtins::error::ErrorObject;
     /// let context = &mut Context::default();
     ///
     /// let error = JsNativeError::error().with_message("error!");
     /// let error_obj = error.to_opaque(context);
     ///
-    /// assert!(error_obj.borrow().is_error());
+    /// assert!(error_obj.is::<ErrorObject>());
     /// assert_eq!(
     ///     error_obj.get(js_string!("message"), context).unwrap(),
     ///     js_string!("error!").into()
@@ -922,20 +924,22 @@ impl JsNativeError {
         let (prototype, tag) = match kind {
             JsNativeErrorKind::Aggregate(_) => (
                 constructors.aggregate_error().prototype(),
-                ErrorKind::Aggregate,
+                ErrorObject::Aggregate,
             ),
-            JsNativeErrorKind::Error => (constructors.error().prototype(), ErrorKind::Error),
-            JsNativeErrorKind::Eval => (constructors.eval_error().prototype(), ErrorKind::Eval),
-            JsNativeErrorKind::Range => (constructors.range_error().prototype(), ErrorKind::Range),
+            JsNativeErrorKind::Error => (constructors.error().prototype(), ErrorObject::Error),
+            JsNativeErrorKind::Eval => (constructors.eval_error().prototype(), ErrorObject::Eval),
+            JsNativeErrorKind::Range => {
+                (constructors.range_error().prototype(), ErrorObject::Range)
+            }
             JsNativeErrorKind::Reference => (
                 constructors.reference_error().prototype(),
-                ErrorKind::Reference,
+                ErrorObject::Reference,
             ),
             JsNativeErrorKind::Syntax => {
-                (constructors.syntax_error().prototype(), ErrorKind::Syntax)
+                (constructors.syntax_error().prototype(), ErrorObject::Syntax)
             }
-            JsNativeErrorKind::Type => (constructors.type_error().prototype(), ErrorKind::Type),
-            JsNativeErrorKind::Uri => (constructors.uri_error().prototype(), ErrorKind::Uri),
+            JsNativeErrorKind::Type => (constructors.type_error().prototype(), ErrorObject::Type),
+            JsNativeErrorKind::Uri => (constructors.uri_error().prototype(), ErrorObject::Uri),
             #[cfg(feature = "fuzz")]
             JsNativeErrorKind::NoInstructionsRemain => {
                 unreachable!(
@@ -1140,18 +1144,18 @@ impl JsNativeErrorKind {
     }
 }
 
-impl PartialEq<ErrorKind> for JsNativeErrorKind {
-    fn eq(&self, other: &ErrorKind) -> bool {
+impl PartialEq<ErrorObject> for JsNativeErrorKind {
+    fn eq(&self, other: &ErrorObject) -> bool {
         matches!(
             (self, other),
-            (Self::Aggregate(_), ErrorKind::Aggregate)
-                | (Self::Error, ErrorKind::Error)
-                | (Self::Eval, ErrorKind::Eval)
-                | (Self::Range, ErrorKind::Range)
-                | (Self::Reference, ErrorKind::Reference)
-                | (Self::Syntax, ErrorKind::Syntax)
-                | (Self::Type, ErrorKind::Type)
-                | (Self::Uri, ErrorKind::Uri)
+            (Self::Aggregate(_), ErrorObject::Aggregate)
+                | (Self::Error, ErrorObject::Error)
+                | (Self::Eval, ErrorObject::Eval)
+                | (Self::Range, ErrorObject::Range)
+                | (Self::Reference, ErrorObject::Reference)
+                | (Self::Syntax, ErrorObject::Syntax)
+                | (Self::Type, ErrorObject::Type)
+                | (Self::Uri, ErrorObject::Uri)
         )
     }
 }

boa_engine/src/object/builtins/jsmap.rs

@@ -153,7 +153,7 @@ impl JsMap {
     /// // `some_object` can be any JavaScript `Map` object.
     /// let some_object = JsObject::from_proto_and_data(
     ///     context.intrinsics().constructors().map().prototype(),
-    ///     ObjectData::map(OrderedMap::new()),
+    ///     OrderedMap::<JsValue>::new(),
     /// );
     ///
     /// // Create `JsMap` object with incoming object.

boa_engine/src/object/jsobject.rs

@@ -118,8 +118,8 @@ impl JsObject {
     /// Creates a new object with the provided prototype and object data.
     ///
     /// This is equivalent to calling the specification's abstract operation [`OrdinaryObjectCreate`],
-    /// with the difference that the `additionalInternalSlotsList` parameter is automatically set by
-    /// the [`ObjectData`] provided.
+    /// with the difference that the `additionalInternalSlotsList` parameter is determined by
+    /// the provided `data`.
     ///
     /// [`OrdinaryObjectCreate`]: https://tc39.es/ecma262/#sec-ordinaryobjectcreate
     pub fn from_proto_and_data<O: Into<Option<Self>>, T: NativeObject>(
@@ -151,8 +151,8 @@ impl JsObject {
     /// Creates a new object with the provided prototype and object data.
     ///
     /// This is equivalent to calling the specification's abstract operation [`OrdinaryObjectCreate`],
-    /// with the difference that the `additionalInternalSlotsList` parameter is automatically set by
-    /// the [`ObjectData`] provided.
+    /// with the difference that the `additionalInternalSlotsList` parameter is determined by
+    /// the provided `data`.
     ///
     /// [`OrdinaryObjectCreate`]: https://tc39.es/ecma262/#sec-ordinaryobjectcreate
     pub(crate) fn from_proto_and_data_with_shared_shape<O: Into<Option<Self>>, T: NativeObject>(

boa_engine/src/value/display.rs

@@ -2,7 +2,7 @@ use std::borrow::Cow;
 
 use crate::{
     builtins::{
-        error::ErrorKind, map::ordered_map::OrderedMap, promise::PromiseState,
+        error::ErrorObject, map::ordered_map::OrderedMap, promise::PromiseState,
         set::ordered_set::OrderedSet, Array, Promise,
     },
     property::PropertyDescriptor,
@@ -193,7 +193,7 @@ pub(crate) fn log_string_from(x: &JsValue, print_internals: bool, print_children
                 } else {
                     format!("Set({size})")
                 }
-            } else if v_bor.is::<ErrorKind>() {
+            } else if v_bor.is::<ErrorObject>() {
                 drop(v_bor);
                 let name: Cow<'static, str> = v
                     .get_property(&utf16!("name").into())

boa_runtime/src/lib.rs

@@ -93,7 +93,7 @@ pub(crate) mod test {
         },
         AssertNativeError {
             source: Cow<'static, str>,
-            kind: builtins::error::ErrorKind,
+            kind: builtins::error::ErrorObject,
             message: &'static str,
         },
         AssertContext {